From dev-return-90522-archive-asf-public=cust-asf.ponee.io@ant.apache.org Tue Feb 6 13:38:38 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 27915180657 for ; Tue, 6 Feb 2018 13:38:38 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 173EE160C45; Tue, 6 Feb 2018 12:38:38 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 570EE160C3A for ; Tue, 6 Feb 2018 13:38:37 +0100 (CET) Received: (qmail 24793 invoked by uid 500); 6 Feb 2018 12:38:36 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 24781 invoked by uid 99); 6 Feb 2018 12:38:35 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Feb 2018 12:38:35 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id A8D86E04FA; Tue, 6 Feb 2018 12:38:35 +0000 (UTC) From: jaikiran To: dev@ant.apache.org Reply-To: dev@ant.apache.org References: In-Reply-To: Subject: [GitHub] ant-ivy pull request #62: IVY-1572 - Check for Thread interruption while res... Content-Type: text/plain Message-Id: <20180206123835.A8D86E04FA@git1-us-west.apache.org> Date: Tue, 6 Feb 2018 12:38:35 +0000 (UTC) Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/62#discussion_r166282397 --- Diff: src/java/org/apache/ivy/plugins/resolver/AbstractPatternsBasedResolver.java --- @@ -91,6 +91,9 @@ protected ResolvedResource findResourceUsingPatterns(ModuleRevisionId moduleRevi Set foundRevisions = new HashSet<>(); boolean dynamic = getSettings().getVersionMatcher().isDynamic(moduleRevision); for (String pattern : patternList) { + if (Thread.currentThread().isInterrupted()) { + return null; --- End diff -- @apupier , I don't think this is the best place to check the thread interruption, but I don't have a better suggestion right now, so unless someone objects, this change is probably fine. However, instead of returning null, can you please throw a (runtime) exception instead. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org