ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jaikiran Pai <jai.forums2...@gmail.com>
Subject Re: ant git commit: Generate manifest files and add automatic module names for JPMS
Date Tue, 06 Feb 2018 08:46:27 GMT
Just to be clear, my -1 was meant for both this commit as well as a 
subsequent commit where some specific jars have been tagged as JPMS 
modules. I think adding this automatic module names just for the sake of 
it isn't a good thing.

-Jaikiran


On 06/02/18 9:38 AM, Jaikiran Pai wrote:
> I agree. -1.
>
> On a related note, I don't think we should be doing any of these 
> commits especially when there's a RC out which we plan to release. 
> IMO, only blocker issues need to be addressed when the RC is out.
>
> -Jaikiran
>
>
> On 06/02/18 1:41 AM, Stefan Bodewig wrote:
>>> Generate manifest files and add automatic module names for JPMS
>> -1
>>
>> please remove the Automatic-Module-Name attributes as our jars are no
>> proper JPMS modules.
>>
>> Stefan
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
>> For additional commands, e-mail: dev-help@ant.apache.org
>>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message