ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: Need a Second Pair of Eyes
Date Wed, 14 Feb 2018 08:52:38 GMT
On 2018-02-14, Stefan Bodewig wrote:

> On 2018-02-14, Jaikiran Pai wrote:

>> You are right. The change introduces a different behaviour than what
>> was there before. Just to be extra sure that we indeed are reading it
>> right, I added a (dummy) test case in my personal repo, which compares
>> the previous logic and the new logic and it does shows that the change
>> indeed introduces a different behaviour.

>> [1]
>> https://github.com/jaikiran/ant/commit/f57b9d5fbca6e9648695bc9d37a27000c0b4aff2#diff-585ed59cf64ef6930e5148094adc322aR21

> Many thanks, Jaikiran, so I'm going to revert that hunk.

I've used a third approach in commit 1fbf712 and checked it in a way
similar to your test.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message