ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jaikiran Pai <jai.forums2...@gmail.com>
Subject Mapped resources NPEs - Potential fix causes a failure in one specific test
Date Fri, 09 Feb 2018 09:06:37 GMT
Recently a couple of bugs have been reported around mapped resources 
where we end up in NullPointerExceptions in various places[1][2]. As 
noted in [1], it needs a fix at a central place and I think I was able 
to fix the root cause as part of this commit[3] that I did an hour or so 
back. However, there's a specific test case[4] in our antunit test suite 
which expects a BuildException to be thrown as part of copy task. That 
test was introduced long back as part of [5] to test another similar 
NPE. I think with the change I now have, it no longer reaches this place 
in the code where the Copy task would end up getting a null from a 
mapper, because various other utility classes already handle this 
contract and skip that resource. As such, the test completes cleanly 
without any NPE and without copying anything, however given that we do 
expect a build failure exception to be thrown, this test is now failing [6].

I need some inputs on how we should go about this specific change/test? 
Should this test continue to expect a exception or is it fine to expect 
that target to complete cleanly (without copying anything)?

[1] https://bz.apache.org/bugzilla/show_bug.cgi?id=62076

[2] https://bz.apache.org/bugzilla/show_bug.cgi?id=62086

[3] 
https://github.com/apache/ant/commit/e3f5250916dc0d9493b45b2d8fc6efe3a0fd9fda#diff-fabf453d75aaafb0dd9080e12d5dddfcR51

[4] 
https://github.com/apache/ant/blob/master/src/tests/antunit/taskdefs/copy-test.xml#L85

[5] https://bz.apache.org/bugzilla/show_bug.cgi?id=39960

[6] 
https://builds.apache.org/job/Ant-Build-Matrix-1.9.x-Linux/OS=xenial,jdk=JDK%201.5%20(latest)/lastCompletedBuild/testReport/src.tests.antunit.taskdefs/copy-test_xml/testResourceWithoutName/

-Jaikiran


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message