ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bodewig <...@git.apache.org>
Subject [GitHub] ant issue #58: Use StringBuilder instead of StringBuffer as it offers high p...
Date Sun, 18 Feb 2018 19:45:08 GMT
Github user bodewig commented on the issue:

    https://github.com/apache/ant/pull/58
  
    The changes to `FixCRLF`, `TaskOutputStream`,  `VerifyJar`, `Message`, `TraxLiaison` and
`RegexpPatternMapper` all change instance variables of classes that might be used in a mutlithreaded
context. In the case of `RegexpPatternMapper`  they are even protected and thus the change
would break backwards compatibility.
    
    Please restrict your change to `StringBuffer`s created as local variables in methods that
are not returned or passed to multiple threads.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message