ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dominique Devienne <ddevie...@gmail.com>
Subject Re: ant-ivy git commit: tidy up the code
Date Fri, 08 Dec 2017 08:53:54 GMT
On Fri, Dec 8, 2017 at 7:53 AM, <gintas@apache.org> wrote:

> Repository: ant-ivy
> Updated Branches:
>   refs/heads/master 1b84f2ee7 -> 12aeeec70
>
> tidy up the code
> -            if ((currentTask.getTaskName() != null)
> +            if (currentTask.getTaskName() != null
>                      && currentTask.getTaskName().equals(((Task)
> task).getTaskName())) {
>                  // The current AntMessageLogger already logs with the same
>                  // prefix as the given task. So we shouldn't do
> anything...
> ...
>


> -        if ((otherRef != null) && OVERRIDE_NOT_ALLOWED.equals(override))
> {
> +        if (otherRef != null && OVERRIDE_NOT_ALLOWED.equals(override)) {
>

Hi Gintas,

Why? I myself prefer having the parens you removed.
Is this some kind of automated code formatter? Or personnal preference?
I've never been one to rely on implicit associativity rule, and like
explicit parens in those cases.

It's not a -1, but maybe we could have a short conversation here on whether
this is desirable or not,
or even if people just don't care.

Thanks, --DD

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message