ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jaikiran <...@git.apache.org>
Subject [GitHub] ant pull request #49: [master branch] - Fix BZ-58683
Date Sun, 10 Dec 2017 08:31:06 GMT
Github user jaikiran commented on a diff in the pull request:

    https://github.com/apache/ant/pull/49#discussion_r155941213
  
    --- Diff: src/main/org/apache/tools/ant/util/SymbolicLinkUtils.java ---
    @@ -30,6 +30,8 @@
      * a symbolic link based on the absent support for them in Java.
      *
      * @since Ant 1.8.0
    + * @deprecated Starting Ant 1.10.2, this utility is deprecated in favour of the symlink
    + *              support introduced in Java {@link java.nio.file.Files} APIs
    --- End diff --
    
    >> Do you intend to change those other occurrences as well?
    
    I do intend to do necessary changes related to this, in subsequent commit(s), when I get
a chance. I didn't want to create one large PR with too many unrelated changes. I added this
deprecation note just so that any new code doesn't end up using this class, now that we are
on Java 7. But I think, it's better to add this deprecation note when I do get to changing
references to this class in some other commits. So I have undone this change and updated the
PR.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message