ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bodewig <...@git.apache.org>
Subject [GitHub] ant issue #49: [master branch] - Fix BZ-58683
Date Sat, 09 Dec 2017 18:08:55 GMT
Github user bodewig commented on the issue:

    https://github.com/apache/ant/pull/49
  
    Thanks @jaikiran, I've added a buch of inline comments.
    
    Overall I'm in favor of this change and if you want to spend the time on fixing the bugzilla
issue in a Java5 friendly way for 1.9.x that would certainly be good - bit not something I'd
see as an requirement.
    
    The `SymlinkTest` still ensures tests are skipped on platforms that are not Unix (see
the `assume` in `setup`). I'm not sure if we can figure out whether Java supports symlinks
on the platform easily but it would certainly be good to test things on non-Unix platforms
if we claim the task should work.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message