From dev-return-90086-apmail-ant-dev-archive=ant.apache.org@ant.apache.org Wed Oct 11 12:54:17 2017 Return-Path: X-Original-To: apmail-ant-dev-archive@www.apache.org Delivered-To: apmail-ant-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8B01A1079C for ; Wed, 11 Oct 2017 12:54:17 +0000 (UTC) Received: (qmail 59438 invoked by uid 500); 11 Oct 2017 12:54:12 -0000 Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 59364 invoked by uid 500); 11 Oct 2017 12:54:12 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 59353 invoked by uid 99); 11 Oct 2017 12:54:12 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Oct 2017 12:54:12 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 0809DDF984; Wed, 11 Oct 2017 12:54:12 +0000 (UTC) From: BruceKuiLiu To: dev@ant.apache.org Reply-To: dev@ant.apache.org Message-ID: Subject: [GitHub] ant pull request #42: Fix the inefficient use of keySet iterator with entryS... Content-Type: text/plain Date: Wed, 11 Oct 2017 12:54:12 +0000 (UTC) GitHub user BruceKuiLiu opened a pull request: https://github.com/apache/ant/pull/42 Fix the inefficient use of keySet iterator with entrySet iterator. The current source code accesses the key and value of a Hashtable entry, using a key that is retrieved from a keySet iterator. It is more efficient to use an iterator on the entrySet of the Hashtable, to avoid the Map.get(key) lookup. http://findbugs.sourceforge.net/bugDescriptions.html#WMI_WRONG_MAP_ITERATOR You can merge this pull request into a Git repository by running: $ git pull https://github.com/BruceKuiLiu/ant master2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant/pull/42.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #42 ---- commit fb817dd2c4b01a1840f1c06940c71de3ec60ce0a Author: Kui LIU Date: 2017-10-11T12:18:19Z Fix the inefficient use of keySet iterator with entrySet iterator. The current source code accesses the key and value of a Hashtable entry, using a key that is retrieved from a keySet iterator. It is more efficient to use an iterator on the entrySet of the Hashtable, to avoid the Map.get(key) lookup. commit ab65a09dc00d9baa55a088dbffeec414fbda9bc9 Author: Kui LIU Date: 2017-10-11T12:42:46Z Fix the inefficient use of keySet iterator with entrySet iterator. The current source code accesses the key and value of a Hashtable entry, using a key that is retrieved from a keySet iterator. It is more efficient to use an iterator on the entrySet of the Hashtable, to avoid the Map.get(key) lookup. http://findbugs.sourceforge.net/bugDescriptions.html#WMI_WRONG_MAP_ITERATOR commit 6a9a466b275b553637277b980139b6297a166483 Author: Kui LIU Date: 2017-10-11T12:51:12Z Fix the inefficient use of keySet iterator with entrySet iterator. The current source code accesses the key and value of a Hashtable entry, using a key that is retrieved from a keySet iterator. It is more efficient to use an iterator on the entrySet of the Hashtable, to avoid the Map.get(key) lookup. http://findbugs.sourceforge.net/bugDescriptions.html#WMI_WRONG_MAP_ITERATOR ---- --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org