ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twogee <...@git.apache.org>
Subject [GitHub] ant-ivy issue #57: fix last inconsistencies in generics
Date Wed, 02 Aug 2017 07:53:21 GMT
Github user twogee commented on the issue:

    https://github.com/apache/ant-ivy/pull/57
  
    Thanks for clarifying.
    
    My point was that the use of the method is limited to two classes: `SearchEngine` and
`ChainResolver` (because it is essentially a proxy).
    
    A quick search seems to indicate that most (if not all) custom resolver implementations
out there extend `AbstractResolver`, and thus providing a default implementation of the method
with the new signature as a wrapper in the abstract class will mitigate the problems due to
the lack of it.
    
    Therefore I would like insist on adding the method to the interface as well as changing
the signature in all resolvers that ship with Ivy. Any public method in the abstract class
should be declared in the interface, and going halfway does not make much sense.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message