Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Ant Developers List" <dev@ant.apache.org>
From: =?utf-8?Q?Nicolas_Lalev=C3=A9e?= <nicolas.lalevee@hibnet.org>
Message-Id: <FE01E0E0-FADA-4922-99DD-8C9FB3CFE4EE@hibnet.org>
Content-Type: multipart/alternative;
 boundary="Apple-Mail=_CCD87F51-BBC6-45C8-ABBA-570984127977"
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: IVYDE-382 proposed patch
Date: Sat, 1 Jul 2017 14:15:46 +0200
In-Reply-To: <2c8269dcc922c9f6a3ac75094e30088b@arctis.at>
Cc: Michael Breu <michael.breu@arctis.at>
To: Ant Developers List <dev@ant.apache.org>,
 alexander.blaas@arctis.at
References: <d1222e23ef0ba706a5d8ebf1b6fba721@arctis.at>
 <698B2F7B-575B-48C6-8A17-9E008F38F8C0@gmail.com>
 <18912D02-3FB9-44E5-B6E6-7D9DB68F58E2@gmail.com>
 <CA3297C1-1FB8-4607-95EE-DA5A876FAC49@hibnet.org>
 <2c8269dcc922c9f6a3ac75094e30088b@arctis.at>
archived-at: Sat, 01 Jul 2017 12:15:56 -0000

--Apple-Mail=_CCD87F51-BBC6-45C8-ABBA-570984127977
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

Hi Alexander,

Yes, it would be really nice if you could create a page documenting the =
new feature.

I have just migrated the documentation of IvyDE to asciidoc, so it will =
be easier to contribute.
I have also squashed and rebased your work on this branch:
https://github.com/apache/ant-ivyde/tree/ivyDECredentials-cleaned =
<https://github.com/apache/ant-ivyde/tree/ivyDECredentials-cleaned>

To contribute you can create a pull request on this branch, we will get =
notified.

Cheers,
Nicolas


> Le 30 juin 2017 =C3=A0 16:52, alexander.blaas@arctis.at a =C3=A9crit :
>=20
> Good afternoon,=20
>=20
> sorry for the delay in my reply. The last two weeks I was very busy =
with
> exams and work.=20
>=20
> We are glad that our proposed patch found its way back to the main
> development path and that perhaps it will be a part of a following
> release :-)=20
>=20
> Is there a way we can support you?=20
>=20
> Should we extend the official IvyDE doc by providing a more
> sophisticated description about the new feature (like you suggested in
> the previous mail)?=20
>=20
> Many greetings from Austria,=20
>=20
> Alexander=20
>=20
> Am 14.06.2017 23:56, schrieb Nicolas Lalev=C3=A9e:
>=20
>> Hi,
>>=20
>> For some reason git apply was refusing to process the patch and was =
just returning an error: corrupt patch at line 1964
>>=20
>> So I played with git commands and work with the sources available on =
github.
>> I have create a branch on the ASF repo, ivyDECredentials, which has =
one commit which squash all the forked commit on github.
>> I have then created another branch, ivyDECredentials-cleaned, which =
rebase the work, remove unnecessary changes like the readme file, and =
did some file formatting.
>>=20
>> Now it needs some review and testing in order to be merged. I'll take =
time to do it but if somebody else if wants to help, another pair of =
eyes on this is very welcomed.
>>=20
>> Also would be welcomed some documentation about this new feature. The =
IvyDE doc is quite complete, it would be really nice to keep it at this =
level.
>>=20
>> Nicolas
>>=20
>>> Le 14 juin 2017 =C3=A0 05:18, J Pai <jai.forums2013@gmail.com> a =
=C3=A9crit :
>>>=20
>>> Hi Alexander,
>>>=20
>>> I actually just realized that your initial mail actually had a patch =
file attached. I didn't notice that before and only today noticed it =
while looking at the mail list archive. So assuming this applies cleanly =
on latest master branch of IvyDE, I think this should be fine too, =
instead of creating a PR. I am not experienced with Eclipse plugins, so =
I personally won't be able to help much, but hopefully someone from the =
IvyDE team will be able to review and decide about this patch. Thank you =
again for contributing this.
>>>=20
>>> -Jaikiran
>>> On 26-May-2017, at 8:28 AM, J Pai <jai.forums2013@gmail.com> wrote:
>>>=20
>>> Hi Alexander,
>>>=20
>>> Thank you for volunteering to provide this feature patch. I had a =
look a the repo you pointed to and read the README. It does seem to =
contain a good amount of work in that branch in multiple commits.=20
>>>=20
>>> To make it easier for whoever will decide about merging these to =
upstream ant-ivyde project, would it to be possible for you to do the =
following:
>>>=20
>>> 1. *Fork* the ant-ivyde project (on github) =
https://github.com/apache/ant-ivyde/ into your account. There's a "Fork" =
button on the right corner of the github page for the repo.
>>> 2. Once forked into your account, you can push your enhancement and =
bug fix related commits to either your master branch of your repo or any =
specific branch of your choice.
>>> - If the bug fixes are independent of the feature, then it would be =
good if they are done in separate branches, so that a separate pull =
request (PR) can be issued.
>>> 3. Once you are ready with the commits, you can then issue a pull =
request (PR) from your repo to the "master" branch of the ant-ivyde =
upstream repo https://github.com/apache/ant-ivyde/.  Typically PRs are =
meant to contain commits that are all specific to a single feature or =
for a specific bug fix.
>>>=20
>>> Once the PRs are submitted, I'm sure one or more members of the =
development team who have relevant knowledge of Eclipse and the project =
will review this and either merge it or provide inputs.
>>>=20
>>> Thanks again for this, both Ivy and IvyDE project has been stagnant =
for a while and with contributions like these, we should be able to =
release out a new version soon.
>>>=20
>>> -Jaikiran
>>>=20
>>> On 25-May-2017, at 1:12 PM, alexander.blaas@arctis.at wrote:
>>>=20
>>> Dear Sir or Madam,
>>>=20
>>> as it was suggested in =
https://issues.apache.org/jira/browse/IVYDE-382?focusedCommentId=3D1601884=
7&page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#=
comment-16018847, we are sending you our proposed patch for =
https://issues.apache.org/jira/browse/IVYDE-382. The corresponding =
patch-file is attached to this email. The source code is available at =
https://github.com/alex-bl/ivyDEextension/tree/ivyDECredentials in the =
branch "ivyDECredentials".=20
>>>=20
>>> Yours sincerely,
>>>=20
>>> Alexander Blaas
>>>=20
>>> <ant-ivyde-credential-storage.patch>
>>> =
---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
>>> For additional commands, e-mail: dev-help@ant.apache.org
>>>=20
>>> =
---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
>>> For additional commands, e-mail: dev-help@ant.apache.org


--Apple-Mail=_CCD87F51-BBC6-45C8-ABBA-570984127977--