Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Ant Developers List" <dev@ant.apache.org>
MIME-Version: 1.0
In-Reply-To: <004001d2ff3b$cb26b2b0$61741810$@de>
References: <c6d83d3c-b5b3-bf75-7989-3eb9d915d935@cloudfabrix.com>
 <CALVNWHWR+xE=0B4fQK9X6zb5eQxePeFgQjrEvDzYcR4drhbzfw@mail.gmail.com>
 <f19f053b-8e14-a0d1-5f48-98f2a0939ce2@gmail.com> <004001d2ff3b$cb26b2b0$61741810$@de>
From: Gintautas Grigelionis <g.grigelionis@gmail.com>
Date: Mon, 17 Jul 2017 22:49:16 +0200
Message-ID: <CALVNWHW+RdTkXqeoPy0RsrA7JvYbByW=AHi4OuADZiiisXrwiA@mail.gmail.com>
Subject: Re: Proposed changes for IVY-735 - Ability to specify timeouts
To: Ant Developers List <dev@ant.apache.org>
Content-Type: multipart/alternative; boundary="94eb2c07d1ea3e98a4055489888f"
archived-at: Mon, 17 Jul 2017 20:49:30 -0000

--94eb2c07d1ea3e98a4055489888f
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Exactly what I had in mind =F0=9F=91=8D

Gintas

2017-07-17 22:32 GMT+02:00 Jan Mat=C3=A8rne (jhm) <apache@materne.de>:

> Maybe you could set the timeout strategy globally:
> /ivysettings/resolvers/@timeout-constraint
>
> <ivysettings>
>    <timeout-contraints>
>       <timeout-constraint name=3D"smaller-timeout" connection-timeout=3D"=
"
> read-timeout=3D"" />
>       ...
>    </timeout-constraints>
>
>    <resolvers timeout-constraint=3D"global-timeout">
>       <ibiblio timeout-constraint=3D"smaller-timeout" ... />
>    </resolvers>
> </ivysettings>
>
>
> Jan
>
>
> > -----Urspr=C3=BCngliche Nachricht-----
> > Von: jai.forums2013@gmail.com [mailto:jai.forums2013@gmail.com]
> > Gesendet: Montag, 17. Juli 2017 06:56
> > An: dev@ant.apache.org
> > Betreff: Re: Proposed changes for IVY-735 - Ability to specify timeouts
> >
> > I think, that's actually a good idea. Defining the timeout constraints
> > separately as named constraints and then referencing them would allow
> > reusing these values on whichever resolvers want to:
> >
> > <ivysettings>
> >
> >   <timeout-contraints>
> >
> >      <timeout-constraint name=3D"smaller-timeout" connection-timeout=3D=
""
> > read-timeout=3D"">
> >
> >      ...
> >
> >   </timeout-constraints>
> >
> >   <resolvers>
> >
> >      <ibiblio timeout-constraint=3D"smaller-timeout" .../>
> >
> >   </resolvers>
> >
> > </ivysettings>
> >
> >
> > -Jaikiran
> >
> >
> > On 14/07/17 10:33 PM, Gintautas Grigelionis wrote:
> > > my =E2=82=AC.02 : currently, all resolvers only have artifact pattern=
s as
> > > child elements, so I'd rather have the timeouts as attributes that
> > > might use references, similarly to cache managers or latest
> > > strategies. That would imply a global default that may be overridden
> > individually.
> > >
> > > Gintas
> > >
> > > 2017-07-14 13:34 GMT+02:00 <jaikiran.pai@cloudfabrix.com>:
> > >
> > >> https://issues.apache.org/jira/browse/IVY-735 is a feature request
> > >> where the users have asked for relevant timeouts while dealing with
> > >> downloads. A few weeks back we had a very brief discussion in an
> > >> unrelated mail where it was proposed that we allow configuring these
> > >> timeout all the way from ivy settings.
> > >>
> > >> I have an initial proposal/attempt to implement this feature. The
> > >> initial changes are here in my personal repo[1]. It's a work in
> > >> progress commit which sets up the necessary interfaces and the flow
> > >> to show what I have in mind. Before proceeding further, I would like
> > >> some inputs on whether this looks fine. Here's a summary of what the
> > changes are going to be:
> > >>
> > >> - Each (dependency) resolver will have the ability to specify
> > >> "timeout constraints"[2].
> > >>
> > >> - These timeout constraints will be specified while defining the
> > >> resolver in the ivy settings file. Imagine something like:
> > >>
> > >>      <ivysettings>
> > >>
> > >>          <resolvers>
> > >>
> > >>              <ibiblio ...>
> > >>
> > >>                  <timeout-constraints connection-timeout=3D""
> > >> read-timeout=3D""/>
> > >>
> > >>              </ibiblio>
> > >>
> > >>      ....
> > >>
> > >> - Each of the resolver will then use these timeout constraints (if
> > >> specified) while resolving the module descriptor and downloading the
> > >> artifacts and dealing with those resources.
> > >>
> > >> - The absence of the timeout constraints will let the resolvers
> > >> behave the way they do currently
> > >>
> > >> The changes in the linked commit deprecate some APIs which weren't
> > >> using timeouts and are replaced by APIs which pass along (an
> > >> optional) TimeoutConstraints[2].
> > >>
> > >> In summary, the change being proposed is that (dependency) resolvers
> > >> have the ability to specify these timeout constraints and then use
> > >> them while dealing with module descriptors and artifacts. One thing
> > I
> > >> have (to some extent intentionally) left out is the ability to
> > define
> > >> a global Ivy settings level or "all resolvers" level
> > >> timeout-constraints. That's because I'm not too sure if it adds much
> > >> value instead of defining it at individual resolver level. I'm
> > however open to adding that support as well.
> > >>
> > >> The linked commit currently doesn't have the necessary support for
> > >> parsing these additional XML elements, but if this whole approach
> > >> looks fine, I will take this further and make sure things work as
> > expected.
> > >>
> > >> [1] https://github.com/jaikiran/ant-ivy/commit/e501d9deca78db8b9
> > >> 34f8a2710ebcfeaeb1456c8
> > >>
> > >> [2] https://github.com/jaikiran/ant-ivy/commit/e501d9deca78db8b9
> > >> 34f8a2710ebcfeaeb1456c8#diff-cd8ed454a52f4afa779574f5600a0ccb
> > >>
> > >>
> > >> -Jaikiran
> > >>
> > >>
> > >> --------------------------------------------------------------------
> > -
> > >> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For
> > additional
> > >> commands, e-mail: dev-help@ant.apache.org
> > >>
> > >>
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
> > commands, e-mail: dev-help@ant.apache.org
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>

--94eb2c07d1ea3e98a4055489888f--