ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jaikiran <...@git.apache.org>
Subject [GitHub] ant-ivy pull request #52: Generics in core
Date Fri, 14 Jul 2017 06:54:45 GMT
Github user jaikiran commented on a diff in the pull request:

    https://github.com/apache/ant-ivy/pull/52#discussion_r127395633
  
    --- Diff: src/java/org/apache/ivy/osgi/p2/XMLInputParser.java ---
    @@ -19,12 +19,11 @@
     
     import java.io.IOException;
     import java.io.InputStream;
    -import java.text.ParseException;
     
     import org.xml.sax.SAXException;
     
     public interface XMLInputParser {
     
    -    void parse(InputStream in) throws ParseException, IOException, SAXException;
    +    void parse(InputStream in) throws IOException, SAXException;
    --- End diff --
    
    Given that `ParseException` is a checked exception, removing this from the throws clause
can cause existing callers of this method (potentially outside of Ivy) to run into compile
issues. Is there some specific reason why this is being removed from the throws clause? If
not, can you please undo this change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message