ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jaikiran <...@git.apache.org>
Subject [GitHub] ant-ivy pull request #48: Generics and Java 7 syntax in osgi and plugins pac...
Date Sat, 01 Jul 2017 13:56:43 GMT
Github user jaikiran commented on a diff in the pull request:

    https://github.com/apache/ant-ivy/pull/48#discussion_r125162592
  
    --- Diff: src/java/org/apache/ivy/plugins/signer/bouncycastle/OpenPGPSignatureGenerator.java
---
    @@ -161,7 +159,7 @@ private PGPSecretKey readSecretKey(InputStream in) throws IOException,
PGPExcept
                         key = k;
                     }
                     if ((keyId != null)
    -                        && (Long.valueOf(keyId, 16).longValue() == (k.getKeyID()
& MASK))) {
    +                        && (Long.valueOf(keyId, 16) == (k.getKeyID() & MASK)))
{
    --- End diff --
    
    I haven't yet found an answer to this in some of the docs I quickly checked. I plan to
check the Java specification later tonight. But if you can revert this one line from the rest
of the PR, then I will go ahead and merge it since the rest of the PR is fine. I can read
up about this a bit more without you having to wait for this PR to be merged.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message