ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From janmaterne <...@git.apache.org>
Subject [GitHub] ant-ivy issue #38: IVY-1475 Throw an explicit BuildException if cachefileset...
Date Tue, 13 Jun 2017 09:28:20 GMT
Github user janmaterne commented on the issue:

    https://github.com/apache/ant-ivy/pull/38
  
    requireCommonBaseDir: 
    - could we replace firstPath by base==null?
    - line 115: additional comment:
      'fail fast: ...'
    - line 117: 'finally we got ...'
    
    getBaseDir:
    - Rename parameter to file1 and file2. For me it seems that both parameters are indepent
from each other. 'base' implies that it's itself a parent of the other.
    - you changed the semantic of the method:
      base==null && file==null --> old=NPE, new=null  (ok with me ;)
      base==null && file!=null --> old=file.paren, new=null (incompatible change)
      base!=null && file==null --> both=null
      base!=null && file!=null --> both=commonBase
    - could be static, maybe moved to a FileUtil-class


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message