ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From janmaterne <...@git.apache.org>
Subject [GitHub] ant-ivy issue #43: Generics and other fixes in tests and tutorials
Date Tue, 13 Jun 2017 07:55:54 GMT
Github user janmaterne commented on the issue:

    https://github.com/apache/ant-ivy/pull/43
  
    Java7 supports the diamond operator and Ivy's baseline is now Java7. So you could use
that (e.g. CCFilter.java).
    
    HMFilter: one advantage of foreach is having a meaningful iterator name. So renaming s/string/value/
would be more readable.
    
    HelloIvy: maybe you could change the hello-message: s/hello ivy !/Hello Ivy!/
    
    src/example/multi-project/projects/find/src/find/Main.java: maybe also change from raw
Collection to Collection<File>, so the foreach could also be typed. This would impact
FindFile.
    --> better in a separate PR
    
    Same for src/example/multi-project/projects/list/src/list/Main.java
    --> better in a separate PR
    
    Same src/example/multi-project/projects/size/src/size/FileSize.java
    --> better in a separate PR
    
    test/java/org/apache/ivy/core/module/id/ModuleIdTest.java
    You changed the semantics:
      assertFalse(moduleId.equals(null)) --> asserts that moduleId is not null (otherwise
a NPE would be thrown) and it's equal-comparison returns false
      assertNotNull(moduleId) --> 'just' assert that moduleId is not null
    --> maybe just place the notnull before the assertfalse?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message