ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nicolas Lalevée <nicolas.lale...@hibnet.org>
Subject Re: Ivy - Buildjobs/PreCommit
Date Wed, 24 May 2017 13:12:03 GMT

> Le 24 mai 2017 à 13:13, Jan Matèrne (jhm) <apache@materne.de> a écrit :
> 
> Not sure about this expertise because my sources were old, but I think the github-plugin
does not support matrix jobs.
> https://github.com/KostyaSha/github-integration-plugin/issues/53
> 
> Maybe a newer plugin version would do, but I could not see the version stamp.
> I'll ask on builds@a.o for help.
> 
> For the meanwhile I deactivated the matrix-PR-job and reactivated the 'old' plain-PR-job.
> 
> If we can't get matrix support we should be to create our own 'matrix' by copying that
job and sticking to certain configurations.
> While a matrix would scale this approach won't. So we should define only 2-4 most interesting
configs like
> - Java7@Unix
> - Java7@Windows
> - Java8@Unix

I think we can even stick to only two configs. Testing on two different OS is the real pain
and I don’t remember having big issues with jvm versions.

We could even for now stick to Windows if most committers are on Unix machines. At least I
am.

And in the end we still have the more exhaustive matrix build which runs after the commit
being merged into the asf repo.

Nicolas

> 
> 
> Jan
> 
>> -----Ursprüngliche Nachricht-----
>> Von: J Pai [mailto:jai.forums2013@gmail.com]
>> Gesendet: Montag, 22. Mai 2017 14:45
>> An: Ant Developers List
>> Betreff: Re: Ivy - Buildjobs/PreCommit
>> 
>> It looks like there might be some issue with the matrix job(s)
>> https://builds.apache.org/job/Ivy-GithubPR-Matrix/2/console
>> 
>> From what I understand of that log, it seems like the parent matrix job
>> (the one above) is correctly checking out the commit from the submitted
>> PR:
>> 
>>> Checking out Revision c1765c71ba4394597409de790bf4529ff97e866e
>> (master)  > git config core.sparsecheckout # timeout=10  > git checkout
>> -f c1765c71ba4394597409de790bf4529ff97e866e
>>> git rev-parse origin/master^{commit} # timeout=10  > git rev-list
>> 239bc0b04a95d6c0f82e59c513de36d68c033c6a # timeout=10
>> 
>> However, it then hands off the job execution to individual
>> Windows/Linux jobs and those jobs https://builds.apache.org/job/Ivy-
>> GithubPR-Matrix/jdk=JDK%201.7%20(latest),os=ubuntu/2/console don’t seem
>> to be able to checkout the commit(s) from the PR and fail with error
>> like:
>> 
>>> Fetching upstream changes from https://github.com/apache/ant-ivy/
>> 
>>> git --version # timeout=10
>>> git fetch --tags --progress
>> https://github.com/apache/ant-ivy/
>> +refs/heads/*:refs/remotes/origin/*
>> Checking out Revision c1765c71ba4394597409de790bf4529ff97e866e (master)
>>> git config core.sparsecheckout # timeout=10  > git checkout -f
>> c1765c71ba4394597409de790bf4529ff97e866e
>> FATAL: Could not checkout c1765c71ba4394597409de790bf4529ff97e866e
>> 
>> hudson.plugins.git.GitException
>> : Command "git checkout -f c1765c71ba4394597409de790bf4529ff97e866e"
>> returned status code 128:
>> stdout:
>> stderr: fatal: reference is not a tree:
>> c1765c71ba4394597409de790bf4529ff97e866e
>> 
>> 	at
>> org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPI
>> Impl.java:1866)
>> 
>> 
>> -Jaikiran
>> 
>> On 22-May-2017, at 12:25 PM, Jan Matèrne (jhm) <apache@materne.de>
>> wrote:
>> 
>>>> On a related note, while we are at this - does Apache infra allow
>> the
>>> jobs to be run against Windows OS Jenkins agents as well? There are a
>>> few issues specifically reported against Windows OS and having the
>> job
>>> run against linux and Windows OS should give a decent coverage for
>> the
>>> upstream code.
>>> 
>>> In Jenkins there is the concept of « Matrix » job.
>>> Here is the ones for Ant:
>>> https://builds.apache.org/view/A/view/Ant/job/Ant-Build-Matrix-1.9.x-
>>> Windows/ <https://builds.apache.org/view/A/view/Ant/job/Ant-Build-
>>> Matrix-1.9.x-Windows/>
>>> https://builds.apache.org/view/A/view/Ant/job/Ant-Build-Matrix-1.9.x-
>>> Linux/
>>> <https://builds.apache.org/view/A/view/Ant/job/Ant-Build-Matrix-
>>> 1.9.x-Linux/>
>>> AFAIR, it used to be able to do on several different OS. I don’t know
>>> why they are split.
>>> 
>>> And I don’t know if it is possible to do it while pulling a PR from
>>> github.
>> 
>> 
>> New buildjob "Ivy-GithubPR-Matrix". I deactivated the old (so we could
>> easily switch back).
>> https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR-Matrix/
>> Basically a copy of the old job:
>> * discard old build jobs (keep 10)
>> * git merge support: fail the build if push fails
>> * github project: git://github.com/apache/ant-ivy.git
>> * git
>> -- repository: git://github.com/apache/ant-ivy.git
>> -- branches: */master (= default)
>> -- clean before checkout
>> -- recursively update submodules
>> -- build commits submitted for validated merge (= PR support)
>> * start build: build pull request to the repository (= PR support)
>> * configuration matrix
>> -- JDK: JDK 1.7 (latest), JDK 1.8 (latest), JDK 9 b156 with jigsaw
>> -- os: label expression = ["ubuntu", "Windows"]
>> * abort the build if it's stuck: absolute 20 minutes
>> * Lock: Ant
>> * build
>> -- ant(standard): clean coverage-report
>> * publish junit: build/test-report/**
>> 
>> 
>> Jan
>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
>> commands, e-mail: dev-help@ant.apache.org
>> 
>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
>> commands, e-mail: dev-help@ant.apache.org
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message