ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jaikiran <...@git.apache.org>
Subject [GitHub] ant-ivy issue #22: Fix transient test failures
Date Wed, 24 May 2017 16:45:08 GMT
Github user jaikiran commented on the issue:

    https://github.com/apache/ant-ivy/pull/22
  
    That's a good find. Looking at that testcase now again, with this additional detail that
you noted, I think the problem here is that the `AbstractLogCircularDependencyStrategy` ends
up using a `IvyContext` which has been populated with a resolve id by that `testRemoveDuplicate2`
test method. Effectively, it thinks that it has already made a note of that circular dependency
and doesn't go ahead and add it or log it. 
    
    I think the way to deal with this is to push/pop the relevant `IvyContext` for these test
methods without each of them interfering with each other. I can't seem to reopen this PR with
the updated testcase, so I'll open a separate PR with the potential fix (plus other few cleanup
that I did in those tests previously). Let's see if that solves this issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message