ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jaikiran <...@git.apache.org>
Subject [GitHub] ant-ivy issue #20: Fix IVY-1522
Date Sun, 21 May 2017 05:55:18 GMT
Github user jaikiran commented on the issue:

    https://github.com/apache/ant-ivy/pull/20
  
    I think both me and Nicolas agree that this "fix" isn't going to solve the case where
this and other similar characters can't be fully supported as long as we are using the module
descriptor attributes (via patterns of course) for file names. That's not the goal of this
PR. 
    
    I haven't ever tested the issue at hand on Windows, so I can't say one way or the other,
but  the issue noted in the JIRA was apparently working in a previous version of Ivy. This
PR is an attempt to do 2 things:
    
    - Let the previously working user project, work again.
    - Change the implementation detail in that method, which is changed in this commit, to
use a different way to identify file system root, instead of relying on the presence of a
specific character to determine that. So irrespective of whether we support the colon (and
other similar characters), this change probably still is worth it.
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message