Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Ant Developers List" <dev@ant.apache.org>
From: pyxide <git@git.apache.org>
To: dev@ant.apache.org
Reply-To: dev@ant.apache.org
References: <git-pr-30-ant@git.apache.org>
In-Reply-To: <git-pr-30-ant@git.apache.org>
Subject: [GitHub] ant issue #30: Enhance scriptdef with a 'compiled' option
Content-Type: text/plain
Message-Id: <20170120154101.F32FEDFA6F@git1-us-west.apache.org>
Date: Fri, 20 Jan 2017 15:41:01 +0000 (UTC)
archived-at: Fri, 20 Jan 2017 15:41:04 -0000

Github user pyxide commented on the issue:

    https://github.com/apache/ant/pull/30
  
    Thank you for your positive review.
    
    > remove part of the reflection logic for master as we target Java8 and javax.script should be there
    
    I really don't have a strong opinion on this point. I did the first prototype with `javax.script` classes but used reflection to accommodate to the rest of the code.
    
    While adding some test units, I discovered that the BSF manager may automatically compiles scripts.
    Had the bsf library been on my Ant classpath before, I wouldn't have developped this feature.
    Should we compile the scripts by default ?
    
    On another note, I added the `encoding` option on the other script components that use
    the `src` attribute (ScriptCondition, ScriptMapper, ScriptFilter, ScriptSelector).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org