ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arcadius <...@git.apache.org>
Subject [GitHub] ant pull request #31: Feature/bugzilla bug 60628 ant get task to accept arbi...
Date Mon, 30 Jan 2017 22:15:18 GMT
Github user arcadius commented on a diff in the pull request:

    https://github.com/apache/ant/pull/31#discussion_r98555008
  
    --- Diff: src/main/org/apache/tools/ant/taskdefs/Get.java ---
    @@ -726,6 +761,14 @@ private URLConnection openConnection(final URL aSource) throws IOException
{
                     connection.setRequestProperty("Accept-Encoding", GZIP_CONTENT_ENCODING);
                 }
     
    +            if (!headers.isEmpty()) {
    --- End diff --
    
    Yes, agree, ```headers``` empty check is not necessary +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message