ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From barney2k7 <...@git.apache.org>
Subject [GitHub] ant pull request #27: Bug 58661: avoid duplicate characters in stack traces
Date Tue, 06 Dec 2016 14:32:03 GMT
GitHub user barney2k7 opened a pull request:

    https://github.com/apache/ant/pull/27

    Bug 58661: avoid duplicate characters in stack traces

    This fixes https://bz.apache.org/bugzilla/show_bug.cgi?id=58661
    
    As suspected, the problem is in the 'br-replace' template that is off by one character
in some cases:
    $secondhalflen is actually less than string-length($secondhalfword) in case the number
of chars in word is
    even. This leads to $firsthalflen being calculated too long, resulting in a duplicated
character.
    
    Note that unlike the patch attached to the bug, this pull requests solves just the duplicate
character problem - nothing else.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/barney2k7/ant Bug-58661

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ant/pull/27.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #27
    
----
commit 0633fe53fb8c49792dcd3ad36e2dcb580763ecea
Author: barney2k7 <barney2k7@gmail.com>
Date:   2016-12-06T14:25:41Z

    Bug 58661: avoid duplicate characters in stack traces
    
    The problem was that $secondhalflen is actually less than
    string-length($secondhalfword) in case the number of chars in word is
    even. This leads to $firsthalflen being calculated too long, resulting
    in a duplicated character.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message