ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jwadamson <...@git.apache.org>
Subject [GitHub] ant pull request #26: corrected comments
Date Fri, 28 Oct 2016 21:06:03 GMT
GitHub user jwadamson opened a pull request:

    https://github.com/apache/ant/pull/26

    corrected comments

    Finally figured out why some behaviors were present. Originally thought sed was trimming
whitespace in its output.
    I had not known that subshell output capture via either `` or "$()" trims whitespace from
the ends.
    
    I updated the comments to specifically mention subshell trimming as the reason for needing
the padding and why the \n is not an issue.
    
    Makes me feel much better about x-platform robustness of this now that I understand these
behaviors were not related to sed version quirks.
    
    Obviously this is just cosmetic.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jwadamson/ant-1 fix-60150_1.9.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ant/pull/26.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #26
    
----
commit 38ad53839479c0f9c42a9f7a69b9966fea5cf6ec
Author: Jeffrey Adamson <jwadamson@us.ibm.com>
Date:   2016-10-28T15:29:32Z

    corrected comments

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message