ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From silviu-burcea <...@git.apache.org>
Subject [GitHub] ant pull request: The JDK 9 module system support for the Javac Ta...
Date Thu, 31 Mar 2016 11:34:10 GMT
Github user silviu-burcea commented on a diff in the pull request:

    https://github.com/apache/ant/pull/16#discussion_r58038934
  
    --- Diff: src/tests/junit/org/apache/tools/ant/taskdefs/JavacTest.java ---
    @@ -244,4 +248,85 @@ public void testTargetOverridesDefault() {
             javac.setTarget("1.5");
             assertEquals("1.5", javac.getTarget());
         }
    +
    +    @Test
    +    public void testModulesourcepathOrSrcDirRequired() {
    +        try {
    +            javac.checkParameters();
    +            fail("Build exception should have been thrown - neither srcDir nor modulesourcepath");
    +        } catch (BuildException e) {
    +            //pass
    --- End diff --
    
    You can use `@Test(expected = BuildException.class)` instead of useless try/catch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message