ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pkures <...@git.apache.org>
Subject [GitHub] ant pull request: increase buffer size to improve transfer speed
Date Wed, 22 Apr 2015 11:44:49 GMT
Github user pkures commented on a diff in the pull request:

    https://github.com/apache/ant/pull/8#discussion_r28864813
  
    --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/ssh/ScpToMessage.java ---
    @@ -36,7 +36,7 @@
     public class ScpToMessage extends AbstractSshMessage {
     
         private static final int HUNDRED_KILOBYTES = 102400;
    -    private static final int BUFFER_SIZE = 1024;
    +    private static final int BUFFER_SIZE = 100*1024;
    --- End diff --
    
    Yes it's possible, but I didn't want to tie them together. The HUNDRED_KILOBYTES constant
is used as a progress display threshold and IMHO should be named PROGRESS_DISPLAY_THRESHOLD
or something like that, but that is left for another patch ;-)  I would then increase the
value of PROGRESS_DISPLAY_THRESHOLD to at least 1MB, on local network 100KB file is quite
small and progress display is really unnecessary. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message