Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Received-SPF: pass (nike.apache.org: local policy)
From: =?iso-8859-1?Q?Jan_Mat=E8rne_=28jhm=29?= <apache@materne.de>
To: <dev@ant.apache.org>
References: <8c924e774a874b0384edf224a5bcafc0@git.apache.org>
In-Reply-To: <8c924e774a874b0384edf224a5bcafc0@git.apache.org>
Subject: AW: ant git commit: Arrays.copyOf is Java 1.6 only
Date: Wed, 21 Jan 2015 11:03:55 +0100
Message-ID: <004701d03561$918ab1b0$b4a01510$@de>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AdA09BfRNh3LQzBNTJqdl7JKyi/99wAbM5sA
Content-Language: de

right, we are tied to Java1.5
http://ant.apache.org/faq.html#java-version


http://www.oracle.com/technetwork/java/eol-135779.html
End of public updates:
Java5: Oct 2009
Java6: Feb 2013
Java7: Apr 2015 (maybe later)
Java8: Mar 2017 (maybe later)

Extended support:
Java5: May 2015 !!!
Java6: Dec 2018
Java7: Jul 2022
Java8: Mar 2025


I think after ending the extended support for Java5 we could update here
this year ...
WDYT?


Jan

> -----Urspr=FCngliche Nachricht-----
> Von: bodewig@apache.org [mailto:bodewig@apache.org]
> Gesendet: Dienstag, 20. Januar 2015 22:00
> An: notifications@ant.apache.org
> Betreff: ant git commit: Arrays.copyOf is Java 1.6 only
>=20
> Repository: ant
> Updated Branches:
>   refs/heads/master 0903005b8 -> 66b5f3f06
>=20
>=20
> Arrays.copyOf is Java 1.6 only
>=20
>=20
> Project: http://git-wip-us.apache.org/repos/asf/ant/repo
> Commit: http://git-wip-us.apache.org/repos/asf/ant/commit/66b5f3f0
> Tree: http://git-wip-us.apache.org/repos/asf/ant/tree/66b5f3f0
> Diff: http://git-wip-us.apache.org/repos/asf/ant/diff/66b5f3f0
>=20
> Branch: refs/heads/master
> Commit: 66b5f3f06ba641ffd22428b8da4f8b14ff45db53
> Parents: 0903005
> Author: Stefan Bodewig <bodewig@apache.org>
> Authored: Tue Jan 20 21:59:36 2015 +0100
> Committer: Stefan Bodewig <bodewig@apache.org>
> Committed: Tue Jan 20 21:59:36 2015 +0100
>=20
> ----------------------------------------------------------------------
>  src/main/org/apache/tools/zip/ZipEntry.java | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
> ----------------------------------------------------------------------
>=20
>=20
> http://git-wip-
> =
us.apache.org/repos/asf/ant/blob/66b5f3f0/src/main/org/apache/tools/zip
> /ZipEntry.java
> ----------------------------------------------------------------------
> diff --git a/src/main/org/apache/tools/zip/ZipEntry.java
> b/src/main/org/apache/tools/zip/ZipEntry.java
> index f463757..f66baf2 100644
> --- a/src/main/org/apache/tools/zip/ZipEntry.java
> +++ b/src/main/org/apache/tools/zip/ZipEntry.java
> @@ -349,12 +349,18 @@ public class ZipEntry extends
> java.util.zip.ZipEntry implements Cloneable {
>      }
>=20
>      private ZipExtraField[] copyOf(ZipExtraField[] src){
> -        return Arrays.copyOf(src, src.length);
> +        return copyOf(src, src.length);
> +    }
> +
> +    private ZipExtraField[] copyOf(ZipExtraField[] src, int length){
> +        ZipExtraField[] cpy =3D new ZipExtraField[length];
> +        System.arraycopy(src, 0, cpy, 0, Math.min(src.length,
> length));
> +        return cpy;
>      }
>=20
>      private ZipExtraField[] getMergedFields() {
>          final ZipExtraField[] zipExtraFields =3D
> -            Arrays.copyOf(extraFields, extraFields.length + 1);
> +            copyOf(extraFields, extraFields.length + 1);
>          zipExtraFields[zipExtraFields.length] =3D unparseableExtra;
>          return zipExtraFields;
>      }
> @@ -367,7 +373,7 @@ public class ZipEntry extends
> java.util.zip.ZipEntry implements Cloneable {
>      private ZipExtraField[] getAllExtraFields() {
>          final ZipExtraField[] allExtraFieldsNoCopy =3D
> getAllExtraFieldsNoCopy();
>          return (allExtraFieldsNoCopy =3D=3D extraFields)
> -            ? copyOf( allExtraFieldsNoCopy) : allExtraFieldsNoCopy;
> +            ? copyOf(allExtraFieldsNoCopy) : allExtraFieldsNoCopy;
>      }
>=20
>      /**
> @@ -401,7 +407,7 @@ public class ZipEntry extends
> java.util.zip.ZipEntry implements Cloneable {
>                      removeExtraField(ze.getHeaderId());
>                  }
>                  final ZipExtraField[] zipExtraFields =3D
> -                    Arrays.copyOf(extraFields, extraFields.length +
> 1);
> +                    copyOf(extraFields, extraFields.length + 1);
>                  zipExtraFields[extraFields.length] =3D ze;
>                  extraFields =3D zipExtraFields;
>              }


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org