ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Antoine Levy Lambert <anto...@gmx.de>
Subject Re: [VOTE] Ivy 2.4.0 Release - take 2
Date Sat, 13 Dec 2014 20:24:25 GMT
So the first error is due to XmlModuleDescriptorWriterTest maybe making a too strong assertion
concerning the order of XML elements in an info tag which is probably irrelevant.

Should we be using XMLUnit to compare the XML files ?

The second error is in org.apache.ivy.plugins.resolver.IBiblioResolverTest. The testcase which
fails - testErrorReport - is attempting to resolve an ivy dependency against an inexistent
repository unknown.host.comx. What happens in this case on my computer is that I am getting
this :

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html>
<head>
<meta http-equiv="refresh" content="0;url=http://searchassist.verizon.com/main?InterceptSource=0&ClientLocation=us&ParticipantID=euekiz39ksg8nwp7iqj2fp5wzfwi5q76&FailureMode=1&SearchQuery=&FailedURI=http%3A%2F%2Funknown.host.comx%2Forg%2Fapache%2Fcommons-fileupload%2F1.0%2Fcommons-fileupload-1.0.pom&AddInType=4&Version=2.1.8-1.90base&Referer=&Implementation=0&method=GET"/>
<script type="text/javascript">url="http://searchassist.verizon.com/main?InterceptSource=0&ClientLocation=us&ParticipantID=euekiz39ksg8nwp7iqj2fp5wzfwi5q76&FailureMode=1&SearchQuery=&FailedURI=http%3A%2F%2Funknown.host.comx%2Forg%2Fapache%2Fcommons-fileupload%2F1.0%2Fcommons-fileupload-1.0.pom&AddInType=4&Version=2.1.8-1.90base&Referer=&Implementation=0&method=GET";if(top.location!=location){var
w=window,d=document,e=d.documentElement,b=d.body,x=w.innerWidth||e.clientWidth||b.clientWidth,y=w.innerHeight||e.clientHeight||b.clientHeight;url+="&w="+x+"&h="+y;}window.location.replace(url);</script>
</head>
<body>
</body>
</html>

in file:/Users/antoine/dev/asf/ant-core/build/cache/org.apache/commons-fileupload/ivy-1.0.xml.original

which is an error message in HTML from my ISP.

Should testErrrorReport be written differently and maybe use a checked in ivy.xml for the
org.apache / commons-fileupload / 1.0 module that it is trying to download from unknown.host.comx
?

Also should PomModuleDescriptorParser#parseDescriptor not rethrow a more informative exception
than this SAX Exception “ErrorAlreay seen doctype” ? Do we have an IvyException class
?

For the vote I am on the edge. On one side I see that these test 2 test failures/errors do
not indicate real serious problems, on the other hand I am afraid of delaying the release
still by more time.

Thoughts ?

Antoin



On Dec 13, 2014, at 1:59 PM, Antoine Levy Lambert <antoine@gmx.de> wrote:

> Hi,
> 
> I just checked out the 2.4.0 tag from git and I ran the build.
> 
> I am getting 2 errors :
> 
> XmlModuleDescriptorWriterTest	testExtraInfosFromMaven	Failure	expected:<...properties__commons.[collections.version>1.0.5</m:properties__commons.collections.version>
<m:properties__commons.logging.version>1.0.4</m:properties__commons.logging].version>
<m:depen...> but was:<...properties__commons.[logging.version>1.0.4</m:properties__commons.logging.version>
<m:properties__commons.collections.version>1.0.5</m:properties__commons.collections].version>
<m:depen...>
> 
> junit.framework.ComparisonFailure: expected:<...properties__commons.[collections.version>1.0.5</m:properties__commons.collections.version>
> <m:properties__commons.logging.version>1.0.4</m:properties__commons.logging].version>
> <m:depen...> but was:<...properties__commons.[logging.version>1.0.4</m:properties__commons.logging.version>
> <m:properties__commons.collections.version>1.0.5</m:properties__commons.collections].version>
> <m:depen...>
> at org.apache.ivy.plugins.parser.xml.XmlModuleDescriptorWriterTest.testExtraInfosFromMaven(XmlModuleDescriptorWriterTest.java:158)
> 
> testErrorReport	Error	Already seen doctype.
> 
> java.text.ParseException: Already seen doctype.
> at org.apache.ivy.plugins.parser.m2.PomModuleDescriptorParser.newParserException(PomModuleDescriptorParser.java:375)
> at org.apache.ivy.plugins.parser.m2.PomModuleDescriptorParser.parseDescriptor(PomModuleDescriptorParser.java:297)
> at org.apache.ivy.plugins.parser.m2.PomModuleDescriptorParser.parseDescriptor(PomModuleDescriptorParser.java:108)
> at org.apache.ivy.core.cache.DefaultRepositoryCacheManager$MyModuleDescriptorProvider.provideModule(DefaultRepositoryCacheManager.java:817)
> at org.apache.ivy.core.cache.ModuleDescriptorMemoryCache.getStale(ModuleDescriptorMemoryCache.java:68)
> at org.apache.ivy.core.cache.DefaultRepositoryCacheManager.getStaledMd(DefaultRepositoryCacheManager.java:834)
> at org.apache.ivy.core.cache.DefaultRepositoryCacheManager.cacheModuleDescriptor(DefaultRepositoryCacheManager.java:1326)
> at org.apache.ivy.plugins.resolver.BasicResolver.parse(BasicResolver.java:538)
> at org.apache.ivy.plugins.resolver.BasicResolver.getDependency(BasicResolver.java:273)
> at org.apache.ivy.plugins.resolver.IBiblioResolver.getDependency(IBiblioResolver.java:506)
> at org.apache.ivy.plugins.resolver.IBiblioResolverTest.testErrorReport(IBiblioResolverTest.java:251)
> Caused by: org.xml.sax.SAXParseException; systemId: file:/Users/antoine/dev/asf/ant-ivy/build/cache/org.apache/commons-fileupload/ivy-1.0.xml.original;
lineNumber: 2; columnNumber: 10; Already seen doctype.
> at org.apache.xerces.parsers.DOMParser.parse(Unknown Source)
> at org.apache.xerces.jaxp.DocumentBuilderImpl.parse(Unknown Source)
> at org.apache.ivy.util.XMLHelper.parseToDom(XMLHelper.java:223)
> at org.apache.ivy.plugins.parser.m2.PomReader.<init>(PomReader.java:122)
> at org.apache.ivy.plugins.parser.m2.PomModuleDescriptorParser.parseDescriptor(PomModuleDescriptorParser.java:118)
> 
> 
> This is running the build with Java 1.7 on Mac OS 10.9.5
> 
> Regards,
> 
> Antoine
> 
> 
> On Dec 13, 2014, at 1:28 PM, Antoine Levy Lambert <antoine@gmx.de> wrote:
> 
>> Hello Nicolas,
>> 
>> is the actual link for the binaries this one :
>> 
>> https://dist.apache.org/repos/dist/dev/ant/ivy/2.4.0/
>> 
>> Antoine
>> On Dec 13, 2014, at 11:45 AM, Nicolas Lalevée <nicolas.lalevee@hibnet.org>
wrote:
>> 
>>> I have built a second release candidate for Ivy 2.4.0
>>> 
>>> The svn tag of this release is: https://git-wip-us.apache.org/repos/asf?p=ant-ivy.git;a=commit;h=0b9db35ee7a94a719e538b04122b86cb997f3a17
>>> 
>>> The artifacts has been published to: https://dist.apache.org/repos/dist/dev/ant/ivy/2.4.0@7405
>>> 
>>> Do you vote for the release of these binaries?
>>> 
>>> [ ] Yes
>>> [ ] No
>>> 
>>> Regards,
>>> 
>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
>> For additional commands, e-mail: dev-help@ant.apache.org
>> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message