Return-Path: X-Original-To: apmail-ant-dev-archive@www.apache.org Delivered-To: apmail-ant-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 83A2D10586 for ; Sun, 12 Jan 2014 18:11:25 +0000 (UTC) Received: (qmail 17898 invoked by uid 500); 12 Jan 2014 18:11:16 -0000 Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 17844 invoked by uid 500); 12 Jan 2014 18:11:14 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 17829 invoked by uid 99); 12 Jan 2014 18:11:09 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 12 Jan 2014 18:11:09 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of charles@dyfis.net designates 209.85.213.170 as permitted sender) Received: from [209.85.213.170] (HELO mail-ig0-f170.google.com) (209.85.213.170) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 12 Jan 2014 18:11:03 +0000 Received: by mail-ig0-f170.google.com with SMTP id m12so2635376iga.1 for ; Sun, 12 Jan 2014 10:10:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dyfis.net; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=hyZeZRVF1c+VrgoqJGl/krELYDZa/DKCBpxmVynzEfY=; b=cZesE7h9uYBKEuLwqKNE1O2NMHvEdMopMWRl0alVbbaWkJYf+GxkBo2/fNak4GNwTO /PMbeti8aovs8Uk9mz+cOMoBflN1dfYh8GzLCYIypvS7g6U5tvs5F2t3CeLtGUJ8QYd0 bkPGYkliD8Mjlf58U0SlNcrfnZf/eE4VEVFBI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=hyZeZRVF1c+VrgoqJGl/krELYDZa/DKCBpxmVynzEfY=; b=AMbNYHiYCIdIqRqn/B6wgWgjJ9Ha0KjsafNNkQD0BcIRvQeAS2bAu+STq292JyIKGC 7VjRRx7iRX6pXCmnz5jXQRuN5FBxmnXWem3zPUHx/68cdzfhvIlDA1AARRCafULpU0fJ UAzab99Ul+gRQSC+mrjfCKPkWK+SyG2c9re9OJuYpeWHL3KUFmugaMW7L6n+mmkhK27T wpMEa48l3FvotjLl57mvwlLfQKCVZuUkaz05UHwKVlfye+RNdQ5lznliDxwEV7Fa9qP+ QC2ld/3VEJinbc8qujKqo++Tkg3Or4QIIdpUXJb7K5OCXp4jk6ld4lhDDpcIk1i191m0 5Lvw== X-Gm-Message-State: ALoCoQlCT7Ylhe/P2y/fH3aGzFlEbQnLx0CWl2TDAXpz4bGaO5R2E4f4daGFJ9d1tPY86WJj7ptG MIME-Version: 1.0 X-Received: by 10.43.61.196 with SMTP id wx4mr17857034icb.6.1389550241922; Sun, 12 Jan 2014 10:10:41 -0800 (PST) Received: by 10.64.8.71 with HTTP; Sun, 12 Jan 2014 10:10:41 -0800 (PST) In-Reply-To: References: Date: Sun, 12 Jan 2014 12:10:41 -0600 Message-ID: Subject: Re: Ivy Code formatting From: Charles Duffy To: Ant Developers List Content-Type: multipart/alternative; boundary=bcaec51dd1f191562304efc9e064 X-Virus-Checked: Checked by ClamAV on apache.org --bcaec51dd1f191562304efc9e064 Content-Type: text/plain; charset=UTF-8 +1 On Sun, Jan 12, 2014 at 11:14 AM, Jean-Louis Boudart < jeanlouis.boudart@gmail.com> wrote: > Hi there, > > While fixing a bug i noticed that ivy source code was not fully formatted. > Eclipse formatter is not exported as a plain file but present through > eclipse project preferences in .settings folder [1]. > > Considering .settings folder is already commited i suggest to activate > "Saved actions" to apply on each save : > > - code formatting > - organize import > > > I also suggest to apply formatting on whole project (could be done in a few > clicks with cleanup feature in eclipse). > > Are you in favor of those code modifications ? > > We could take the opportunity to cut this before 2.4.0 release. > > PS: This could aslo applied on others subprojects (ant for example) > > [1] > > https://svn.apache.org/repos/asf/ant/ivy/core/trunk/.settings/org.eclipse.jdt.core.prefs > > -- > Jean Louis Boudart > Independent consultant > Apache EasyAnt commiter http://ant.apache.org/easyant/ > --bcaec51dd1f191562304efc9e064--