Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Received-SPF: softfail (athena.apache.org: transitioning domain of
 nicolas.lalevee@hibnet.org does not designate 216.86.168.183 as permitted
 sender)
Content-Type: text/plain; charset=iso-8859-1
Mime-Version: 1.0 (Apple Message framework v1084)
Subject: Re: Argument Processor "plugin"
From: =?iso-8859-1?Q?Nicolas_Lalev=E9e?= <nicolas.lalevee@hibnet.org>
In-Reply-To: 
 <CAE9L6G3861tieRyk+VoWQ3vZ-JckSQ+GR2o8F4UgAHki--o5zg@mail.gmail.com>
Date: Wed, 29 Aug 2012 17:42:59 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <F30705F2-D757-48DA-AD3D-B17BDBED123A@hibnet.org>
References: <8AA69FB0-5879-4823-B106-F10C96A0AB21@hibnet.org>
 <CAE9L6G3861tieRyk+VoWQ3vZ-JckSQ+GR2o8F4UgAHki--o5zg@mail.gmail.com>
To: "Ant Developers List" <dev@ant.apache.org>


Le 29 ao=FBt 2012 =E0 16:41, Matt Benson a =E9crit :

> Comments:
>=20
> - ArgumentProcessor#readArgument() should return a negative number for
> unsupported args, otherwise a separate boolean #supports(arg) method
> and a declared IllegalArgumentException from #readArgument()

Reviewing this, maybe a better method would be:
int readArgument(String[] args, int pos);
which returns the new position, the same as the one provided is not =
supported.
That way we can have a variable number of custom arguments.

> - Prefer e.g. Appendable to StringBuffer in
> ArgumentProcessor#printUsage() signature, or unless there is a good
> reason for the configurable line separator, PrintStream or PrintWriter

Actually, in the current implementation, any reason all the message is =
buffered before being put to System.out ?
Any reason not to do System.out.println rather than StringBuffer.append( =
+ line.separator) ?

> I am generally in favor of the idea, so as long as the APIs are as
> nice as they can be all the internals are negotiable.

Thanks for the review,
Nicolas

>=20
> Thanks,
> Matt
>=20
> On Wed, Aug 29, 2012 at 8:35 AM, Nicolas Lalev=E9e
> <nicolas.lalevee@hibnet.org> wrote:
>> I would like to add to Ant the possibility to define custom command =
line options.
>>=20
>> This is motivated by the experiment I am doing with the AntDSL and =
the import model I am trying to revisit (if anybody is interested, at =
some point I will probably discuss it on easyant-dev, but we can also =
discuss here). I want things to happen before the build file is being =
parsed and I want it to happen only if the end user has requested it.
>>=20
>> I have not committed it because it is a kind of important door =
opening in Ant's API. And it is only required by an experiment. EasyAnt =
has some custom arguments too, it could benefit from it, but for now it =
has it own "main" implementation and so has a full control of argument =
parsing. So there is no real use case. yet :)
>>=20
>> So I would like some feed back before proceeding. The suggested patch =
is here:
>> =
https://svn.apache.org/repos/asf/ant/sandbox/antdsl/branches/import-experi=
ment/argument-processor.patch
>>=20
>> Nicolas
>>=20
>>=20
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
>> For additional commands, e-mail: dev-help@ant.apache.org
>>=20
>=20
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>=20


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org