Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Received-SPF: pass (athena.apache.org: domain of gudnabrsam@gmail.com
 designates 209.85.212.45 as permitted sender)
MIME-Version: 1.0
Reply-To: gudnabrsam@gmail.com
In-Reply-To: <F30705F2-D757-48DA-AD3D-B17BDBED123A@hibnet.org>
References: <8AA69FB0-5879-4823-B106-F10C96A0AB21@hibnet.org>
	<CAE9L6G3861tieRyk+VoWQ3vZ-JckSQ+GR2o8F4UgAHki--o5zg@mail.gmail.com>
	<F30705F2-D757-48DA-AD3D-B17BDBED123A@hibnet.org>
Date: Wed, 29 Aug 2012 11:44:09 -0500
Message-ID: 
 <CAE9L6G3yzfz69vbrSExNQPrpU-A+H2Od7NCuC_Ur+tHCnA9nkg@mail.gmail.com>
Subject: Re: Argument Processor "plugin"
From: Matt Benson <gudnabrsam@gmail.com>
To: Ant Developers List <dev@ant.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Wed, Aug 29, 2012 at 10:42 AM, Nicolas Lalev=E9e
<nicolas.lalevee@hibnet.org> wrote:
>
> Le 29 ao=FBt 2012 =E0 16:41, Matt Benson a =E9crit :
>
>> Comments:
>>
>> - ArgumentProcessor#readArgument() should return a negative number for
>> unsupported args, otherwise a separate boolean #supports(arg) method
>> and a declared IllegalArgumentException from #readArgument()
>
> Reviewing this, maybe a better method would be:
> int readArgument(String[] args, int pos);
> which returns the new position, the same as the one provided is not suppo=
rted.
> That way we can have a variable number of custom arguments.

Sounds good.  Reminds me of ParsePosition etc.

>
>> - Prefer e.g. Appendable to StringBuffer in
>> ArgumentProcessor#printUsage() signature, or unless there is a good
>> reason for the configurable line separator, PrintStream or PrintWriter
>
> Actually, in the current implementation, any reason all the message is bu=
ffered before being put to System.out ?
> Any reason not to do System.out.println rather than StringBuffer.append( =
+ line.separator) ?

Not sure, but using PrintStream would allow Ant Main to have the
ArgumentProcessor write directly to System.out or not.  :D

Matt

>
>> I am generally in favor of the idea, so as long as the APIs are as
>> nice as they can be all the internals are negotiable.
>
> Thanks for the review,
> Nicolas
>
>>
>> Thanks,
>> Matt
>>
>> On Wed, Aug 29, 2012 at 8:35 AM, Nicolas Lalev=E9e
>> <nicolas.lalevee@hibnet.org> wrote:
>>> I would like to add to Ant the possibility to define custom command lin=
e options.
>>>
>>> This is motivated by the experiment I am doing with the AntDSL and the =
import model I am trying to revisit (if anybody is interested, at some poin=
t I will probably discuss it on easyant-dev, but we can also discuss here).=
 I want things to happen before the build file is being parsed and I want i=
t to happen only if the end user has requested it.
>>>
>>> I have not committed it because it is a kind of important door opening =
in Ant's API. And it is only required by an experiment. EasyAnt has some cu=
stom arguments too, it could benefit from it, but for now it has it own "ma=
in" implementation and so has a full control of argument parsing. So there =
is no real use case. yet :)
>>>
>>> So I would like some feed back before proceeding. The suggested patch i=
s here:
>>> https://svn.apache.org/repos/asf/ant/sandbox/antdsl/branches/import-exp=
eriment/argument-processor.patch
>>>
>>> Nicolas
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
>>> For additional commands, e-mail: dev-help@ant.apache.org
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
>> For additional commands, e-mail: dev-help@ant.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org