Return-Path: X-Original-To: apmail-ant-dev-archive@www.apache.org Delivered-To: apmail-ant-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1DAB89047 for ; Tue, 14 Feb 2012 14:29:46 +0000 (UTC) Received: (qmail 82356 invoked by uid 500); 14 Feb 2012 14:29:45 -0000 Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 82303 invoked by uid 500); 14 Feb 2012 14:29:45 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 82295 invoked by uid 99); 14 Feb 2012 14:29:45 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Feb 2012 14:29:45 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of jak-ant-dev@m.gmane.org designates 80.91.229.3 as permitted sender) Received: from [80.91.229.3] (HELO plane.gmane.org) (80.91.229.3) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Feb 2012 14:29:36 +0000 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1RxJNb-0004VL-0Y for dev@ant.apache.org; Tue, 14 Feb 2012 15:29:15 +0100 Received: from c-174-62-212-174.hsd1.ma.comcast.net ([174.62.212.174]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 14 Feb 2012 15:29:15 +0100 Received: from jesse.glick by c-174-62-212-174.hsd1.ma.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 14 Feb 2012 15:29:15 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: dev@ant.apache.org From: Jesse Glick Subject: Re: Property expansion in macrodef attributes Date: Tue, 14 Feb 2012 09:29:03 -0500 Organization: Oracle Corp. / NetBeans Lines: 17 Message-ID: References: <87aa4oqs0d.fsf@v35516.1blu.de> <87vcn9zj0y.fsf@v35516.1blu.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: c-174-62-212-174.hsd1.ma.comcast.net User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111229 Thunderbird/9.0 In-Reply-To: <87vcn9zj0y.fsf@v35516.1blu.de> X-Virus-Checked: Checked by ClamAV on apache.org On 02/14/2012 07:39 AM, Stefan Bodewig wrote: > Most likely you don't want double expansion in most cases. Right, but how often would you even notice the difference? Usually property values do not themselves contain interpolable variables, as seen by the fact that this problem has just been reported twice since macrodef was introduced. > The biggest problem I see is AntUnit. Here the macro is defined in a > different place and we'd need a new release that requires Ant 1.8.3 to > fix it. True; so release a new AntUnit - a much smaller user audience than Ant itself I suppose. > add the attribute to trunk but make trunk's behavior > default to not expand ${} twice (flagging it as breaking BWC) This would cause a major problem for the many scripts out there which rely on the current behavior. They could not run unchanged on 1.9 (and few people will find this item in the release notes, much less understand its implications); nor could they be fixed in advance, since the attribute would be rejected by 1.8.x. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org