ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: svn commit: r1154551 - in /ant/core/trunk/src: main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTestRunner.java tests/antunit/taskdefs/optional/junit/xmlformatter-test.xml
Date Mon, 08 Aug 2011 03:57:35 GMT
On 2011-08-08, Bruce Atherton wrote:

> I don't think the fix is a bad idea although it is certainly
> hackish. Bob was right that a regular expression would be a somewhat
> better solution, but that is way more intrusive a change and still
> wouldn't always do the right thing.

That's what I thought as well.  It would still have suppressed a failure
message like "expected 6 more ...".

> This change seems to get the job done addressing the known problems
> without overengineering, so +1.

Thanks

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message