ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nicolas Lalevée <nicolas.lale...@hibnet.org>
Subject Re: svn commit: r1075566 - in /ant/ivy/core/trunk: ./ doc/use/ src/java/org/apache/ivy/ant/ src/java/org/apache/ivy/core/retrieve/
Date Wed, 02 Mar 2011 09:26:24 GMT

Le 2 mars 2011 à 09:05, Maarten Coene a écrit :

>> This feature looks great, but I'm starting now (it took me some time  yeah :)) 
>> to have some doubt on the implementation. I'll just raise them  to get some 
>> other point of view.
> 
> Good to see someone is actually watching my commits :-)
> 
> 
>> And it seems than the Ant API is leaking into Ivy core here. RetrieveOption is 
>> depending on FileNameMapper which is then depending on Mapper from Ant. 
>> Shouldn't we try to get Ivy loadable without Ant ?
> 
> 
> The FileNameMapper where the RetrieveOptions is depending on is not the 
> FileNameMapper from Ant, but an interface in the org.apache.ivy.core.retrieve 
> package. Maybe not the best choice of giving it the same name as the 
> FileNameMapper from Ant, but I couldn't think of a better one at that time. 
> Anyway, apart from the naming clash, Ivy core is still independent from the Ant 
> API.

ha, of course. I didn't saw the interface in between which nicely separate Ant code from Ivy
one. So this is ok. I shouldn't read code that late at night :)

Nicolas


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message