ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dominique Devienne <ddevie...@gmail.com>
Subject Re: svn commit: r1032922 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/BindTargets.java
Date Tue, 09 Nov 2010 16:55:46 GMT
2010/11/9 Nicolas Lalevée <nicolas.lalevee@hibnet.org>:
>> From the doc you just checked in, I now read:
>>
>> +<p>The bindtargets task may only be used as a top-level task. This means that
>> +it may not be used in a target.</p>
>>
>> So maybe I was wrong. I didn't see the code enforcing that though?
>> What prevents this task from being inside a target?
>
> I have to admit I have blindly trusted the existing code in ImportTask.java. In the execute
there is:
>        if (getOwningTarget() == null
>            || !"".equals(getOwningTarget().getName())) {
>            throw new BuildException("import only allowed as a top-level task");
>        }

I missed that, thanks. If the doc clearly state that this is just
syntax sugar and show what the equivalent syntax is using <target>,
then I have no further comments ;) --DD

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message