ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt Benson <gudnabr...@gmail.com>
Subject Re: [POLL] Bug 48804
Date Fri, 23 Apr 2010 16:40:05 GMT

On Apr 23, 2010, at 4:29 AM, Stefan Bodewig wrote:

> Hi all,
>
> currently extension-point and import don't play together like they are
> supposed to.  You can't extend an imported extension point with a  
> target
> from the importing build file (which is the primary use-case, really).
>
> Attached to this bug is a patch that fixes the problem (including an
> AntUnit test that fails in 1.8.0).
>
> The same patch breaks a different AntUnit test, namely
> testExtensionPointMustBeKnown in extension-point-test.xml.  This test
> asserts that you can't extend an extension point from the same build
> file before that extension point has been defined.  I.e. you can't do
>
>   <target name="bar" extensionOf="foo"/>
>   <extension-point name="foo"/>
>
> Personally I think the changed behavior isn't a bad thing, the old
> behavior isn't documented and we shouldn't even try to keep it.
>
> What do you think?
>

I don't see any harm in allowing an extensionOf foo to be declared in  
the same buildfile as extension-point foo.  In contrast, I have been  
frustrated by the primary issue from the referenced bugrep.  Which  
all translates to my being in general agreement with your opinion.

-Matt

> Stefan
>
> PS: I'd love to see this fixed with Ant 1.8.1.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message