ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: svn commit: r932456 - /ant/core/trunk/src/main/org/apache/tools/ant/PropertyHelper.java
Date Mon, 12 Apr 2010 04:20:14 GMT
On 2010-04-09, Matt Benson <gudnabrsam@gmail.com> wrote:

> On Apr 9, 2010, at 10:34 AM, Stefan Bodewig wrote:

>> On 2010-04-09, <mbenson@apache.org> wrote:

>>> Address indexOf inefficiency in PropertyHelper embedded
>>> skip-double-dollar propertyexpander implementation.

>> Maybe we should also modify the code in DEFAULT_EXPANDER since it will
>> call indexOf repeatedly as well.

> Let me check that.

Thanks.

>> I've started to write a test for this but even with a couple MB of
>> random text and property references I fail to see any big performance
>> differences between 1.8.0 and 1.7.1 on my machine.

> I wondered about that.  :|  Do what we can for now I guess?

Bugzilla Issue 48961 has an example build file attached to it that I'm
going to try.  In Issue 49079 Paul has already confirmed the change has
fixed the problem, so it looks the repeated indexOfs really were causing
it.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message