ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: [PATCH] JUnitTestRunner.filterStack(String) does not flush BufferedWriter
Date Mon, 01 Feb 2010 09:15:29 GMT
On 2010-02-01, Stefan Bodewig <bodewig@apache.org> wrote:

> I'll revisit the remaining classes I have changed to ensure they close
> the writers now if they didn't do so before.

I've identified a few cases where the writer wouldn't get flushed or
closed in the error case - but things should be fine with the revision
tagged for 1.8.0 for the normal no-error case.  I'm not sure it is
important that the broken result of a sent email message is complete if
it is broken anyway.

Anyway, while revisiting all classes that use BufferedWriter I've added
a few finally blocks and changed a few handmade "if != null close"
blocks with FileUtils, no real issues.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message