ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: [PATCH] JUnitTestRunner.filterStack(String) does not flush BufferedWriter
Date Tue, 02 Feb 2010 04:54:19 GMT
On 2010-02-01, N C <nc1500@yahoo.com> wrote:

> --- On Mon, 2/1/10, Stefan Bodewig <bodewig@apache.org> wrote:

>> I'll revisit the remaining classes I have changed to ensure
>> they close the writers now if they didn't do so before.

> If you haven't, you might want to take a look at
> PlainJUnitResultFormatter.  It isn't clear to me that the
> BufferedWriter "wri" is properly flushed under exceptional conditions,
> but I don't know the code well enough.

This was one of several places where I changed the code in the error
case.  Here like in other places the stream wouldn't get flushed if an
exception occured while writing - but the flush will most likely not
succeed in this case anyway, so the change won't have much of an impact.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message