ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: [PATCH] JUnitTestRunner.filterStack(String) does not flush BufferedWriter
Date Mon, 01 Feb 2010 05:06:46 GMT
On 2010-01-30, N C <nc1500@yahoo.com> wrote:

> In Revision 793462, a BufferedWriter was added to
> JUnitTestRunner.filterStack(String).

Prior to that there was a PrintWriter instead of the BufferedWriter and
it was replaced here like in several other classes.

> However, the BufferedWriter was not flushed before returning the
> underlying StringWriter's contents.  This may exclude all or part of
> the filtered stack trace from the returned String.

Good catch.  The PrintWriter wasn't closed before the change either and
since I only changed the writer implementation the buffering now caused
a loss of data.

I'll revisit the remaining classes I have changed to ensure they close
the writers now if they didn't do so before.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message