ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Antoine Levy Lambert <anto...@gmx.de>
Subject Re: Command Line Property Overrides Broken in trunk
Date Wed, 24 Feb 2010 12:43:23 GMT

Hi,

this check in could be it :

peterreilly@apache.org wrote:
> Author: peterreilly
> Date: Mon Feb 22 15:24:02 2010
> New Revision: 912610
>
> URL: http://svn.apache.org/viewvc?rev=912610&view=rev
> Log:
> BZ48768: invalid ignoring of property setting in property file
>
> Modified:
>     ant/core/trunk/src/main/org/apache/tools/ant/property/ResolvePropertyMap.java
>
> Modified: ant/core/trunk/src/main/org/apache/tools/ant/property/ResolvePropertyMap.java
> URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/property/ResolvePropertyMap.java?rev=912610&r1=912609&r2=912610&view=diff
> ==============================================================================
> --- ant/core/trunk/src/main/org/apache/tools/ant/property/ResolvePropertyMap.java (original)
> +++ ant/core/trunk/src/main/org/apache/tools/ant/property/ResolvePropertyMap.java Mon
Feb 22 15:24:02 2010
> @@ -57,12 +57,6 @@
>              throw new BuildException(
>                  "Property " + name + " was circularly " + "defined.");
>          }
> -        // Note: the master overrides (even if the name is subsequently
> -        //       prefixed)
> -        Object masterProperty = master.getProperty(name);
> -        if (masterProperty != null) {
> -            return masterProperty;
> -        }
>          try {
>              seen.add(name);
>              return parseProperties.parseProperties((String) map.get(name));
>
>   
Regards,

Antoine

Stefan Bodewig wrote:
> Hi all,
>
> many of the latest Gump builds stopped working, see
> <http://vmgump.apache.org/gump/public/project_todos.html> and look at
> those with "duration in state" equal to 1 (or 2 if you read this mail in
> a few hours).
>
> Common to all those failures is something like this:
>
> build.xml:
>
> <project>
>   <property name="version" value="X.Y"/>
>   <jar destfile="project-${version}.jar" .../>
> </project>
>
> $ ant -Dversion=A
>
> [jar] Building jar: project-X.Y.jar
>
> Has anything broken command line properties or property immutability?
>
> I haven't found any time to look into it but maybe anybody else recalls
> the latest changes and can pinpoint the problem.
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>   


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message