ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jesse Glick <Jesse.Gl...@Sun.COM>
Subject Re: svn commit: r910955 [1/2] - in /ant/core/trunk/src/main/org/apache/tools: ant/ ant/helper/ ant/launch/ ant/taskdefs/ ant/taskdefs/compilers/ ant/taskdefs/condition/ ant/taskdefs/email/ ant/taskdefs/optional/ejb/ ant/taskdefs/optional/image/ ant/taskdef...
Date Wed, 17 Feb 2010 16:54:56 GMT
bodewig@apache.org wrote:
> if user input is compared to fixed strings in a case insensitive manner we should use
the default locale.  Use Locale.ENGLISH consistently

Perhaps I'm not understanding the point of this.

> URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/Project.java?rev=910955&r1=910954&r2=910955&view=diff
>      public static boolean toBoolean(String s) {
> -        return ("on".equalsIgnoreCase(s)
> -                || "true".equalsIgnoreCase(s)
> -                || "yes".equalsIgnoreCase(s));
> +        String lc = s == null ? null : s.toLowerCase(Locale.ENGLISH);
> +        return ("on".equals(lc)
> +                || "true".equals(lc)
> +                || "yes".equals(lc));

This should result in exactly the same behavior, except slower. So... why?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message