Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Received-SPF: pass (athena.apache.org: domain of gudnabrsam@gmail.com
 designates 209.85.221.177 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:content-type:message-id
         :content-transfer-encoding:from:subject:date:to:x-mailer;
        b=G4JszfksToLpxDT8DruNEKAEj3IFHCP2KpvF83NGw+tHeGad1S8iLdXMqCqqB2dOYi
         YJRBF58TsGe3hejormfVQt/vLt7+hGwqc5RH3UJQ258EWCuYuol0CiQqVfqMdNzZNWqo
         9SCRFhjlPF3feIa6ah1bZuJWhg7peLnwfYDCI=
Mime-Version: 1.0 (Apple Message framework v753.1)
In-Reply-To: <hir2d6$4ln$1@ger.gmane.org>
References: <20100114232648.557FA23889DD@eris.apache.org>
 <4B4FAA98.9020807@sun.com> <66599455-131C-4AF1-BA6A-6FE1D93FF04B@gmail.com>
 <5B747351-1B81-4DA2-92FE-32ED4A7C77B7@gmail.com> <hir2d6$4ln$1@ger.gmane.org>
Content-Type: text/plain; charset=UTF-8; delsp=yes; format=flowed
Message-Id: <9601624B-9D70-4FE5-839F-5C495DCAC5BB@gmail.com>
Content-Transfer-Encoding: quoted-printable
From: Matt Benson <gudnabrsam@gmail.com>
Subject: Re: svn commit: r899468 - in /ant/antlibs/props/trunk:
 docs/index.html src/main/org/apache/ant/props/EncodeURLEvaluator.java
 src/main/org/apache/ant/props/antlib.xml src/tests/antunit/encodeURL-test.xml
Date: Sat, 16 Jan 2010 12:10:55 -0600
To: "Ant Developers List" <dev@ant.apache.org>


On Jan 15, 2010, at 6:48 PM, Jesse Glick wrote:

> Matt Benson wrote:
>> Java 5 blows up when call toURI() against a URL with a space =20
>> included.
>
> Which is correct; such a URL is invalid:
>
> $ jrunscript
> js> new java.net.URL("file:/tmp/foo bar").toURI()
> script error: sun.org.mozilla.javascript.internal.WrappedException: =20=

> Wrapped java.net.URISyntaxException: Illegal character in path at =20
> index 13: file:/tmp/foo bar (<STDIN>#1) in <STDIN> at line number 1
> js> new java.net.URL("file:/tmp/foo%20bar").toURI()
> file:/tmp/foo%20bar
>
> Maybe I'm missing the purpose of EncodeURLEvaluator, but where =20
> would you get a bogus URL like that from to begin with? Surely not =20
> from <makeurl> on a file, which ought to escape spaces in =20
> filenames. I assumed that the purpose was just to encode non-ASCII =20
> characters, for which toURI is fine:
>

The main idea here is to allow folk to use URLs containing e.g. =20
spaces that their browser will accept and silently convert for them.

> js> new java.net.URL("file:/tmp/foo=C4=8Dbar").toURI().toASCIIString()
> file:/tmp/foo%C4%8Dbar
>
> Or are you trying to encode path sequences (rather than complete =20
> URLs)? But then there is an easier way, without using URL at all:
>
> js> new java.net.URI(null, "foo bar", null).rawPath
> foo%20bar
>
> Anyway does this belong in Ant 1.8.0 so late in the release cycle?
>

Ah, but it's not in Ant--it's in the props antlib!  -Matt

>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org