Return-Path: Delivered-To: apmail-ant-dev-archive@www.apache.org Received: (qmail 50037 invoked from network); 20 Jan 2010 16:07:04 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 20 Jan 2010 16:07:04 -0000 Received: (qmail 34764 invoked by uid 500); 20 Jan 2010 16:07:04 -0000 Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 34640 invoked by uid 500); 20 Jan 2010 16:07:03 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 34625 invoked by uid 99); 20 Jan 2010 16:07:03 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jan 2010 16:07:03 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of antoine@gmx.de designates 213.165.64.20 as permitted sender) Received: from [213.165.64.20] (HELO mail.gmx.net) (213.165.64.20) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 20 Jan 2010 16:06:54 +0000 Received: (qmail invoked by alias); 20 Jan 2010 16:06:33 -0000 Received: from vpn2.citytimenyc.com (EHLO antoine-levy-lamberts-macbook.local) [38.100.172.132] by mail.gmx.net (mp050) with SMTP; 20 Jan 2010 17:06:33 +0100 X-Authenticated: #22961642 X-Provags-ID: V01U2FsdGVkX1/oXBZuPHzo9MFf/7UUzcrGJVbcc4r51RegmnMqkq y2r56eHlnoD0QI Message-ID: <4B572A0A.2020505@gmx.de> Date: Wed, 20 Jan 2010 11:06:34 -0500 From: Antoine Levy Lambert User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812) MIME-Version: 1.0 To: Ant Developers List Subject: Re: svn commit: r901218 - in /ant/core/trunk: WHATSNEW src/main/org/apache/tools/ant/taskdefs/optional/ssh/Scp.java References: <20100120144144.4230223889D5@eris.apache.org> <4B5719A7.5090700@apache.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.56000000000000005 X-Virus-Checked: Checked by ClamAV on apache.org I think it is OK to commit bug fixes, but not OK to introduce new concepts. Just my 2cents. Antoine Matt Benson wrote: > I also have a few quite minor things, so am interested in the > community opinion here. > > On Jan 20, 2010, at 8:56 AM, Steve Loughran wrote: > >> >> Having just checked this in, I was struck by a thought of guilt: >> should I have done this given we are in the RC phase? I'm just >> looking at what (minor) changes I have in my local ant build (this & >> some better error and OOM handling in the junit result formatters). >> I've stuck this in, but technically it's still a code change, right? >> >> I can move this patch to a branch instead. >> >> -steve >> >> stevel@apache.org wrote: >>> Author: stevel >>> Date: Wed Jan 20 14:41:43 2010 >>> New Revision: 901218 >>> URL: http://svn.apache.org/viewvc?rev=901218&view=rev >>> Log: >>> task didn't report build file location when a remote operation >>> failed >>> Bugzilla Report 48578. >>> Modified: >>> ant/core/trunk/WHATSNEW >>> >>> ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/ssh/Scp.java >>> >>> Modified: ant/core/trunk/WHATSNEW >>> URL: >>> http://svn.apache.org/viewvc/ant/core/trunk/WHATSNEW?rev=901218&r1=901217&r2=901218&view=diff >>> >> >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org >> For additional commands, e-mail: dev-help@ant.apache.org >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org > For additional commands, e-mail: dev-help@ant.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org