ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: svn commit: r812573 - in /ant/core/trunk/src: etc/testcases/taskdefs/manifestclasspath.xml main/org/apache/tools/ant/taskdefs/ManifestClassPath.java tests/junit/org/apache/tools/ant/taskdefs/ManifestClassPathTest.java
Date Wed, 09 Sep 2009 03:17:58 GMT
On 2009-09-08, Dominique Devienne <ddevienne@gmail.com> wrote:

> On Tue, Sep 8, 2009 at 11:16 AM, <bodewig@apache.org> wrote:
>> Author: bodewig
>> Date: Tue Sep  8 16:16:54 2009
>> New Revision: 812573

>> URL: http://svn.apache.org/viewvc?rev=812573&view=rev
>> Log: Use FileUtils.getRelativePath which knows how to deal with drive letters.  PR
44499
>> [...]
>>>  <target name="testDifferentDrive">
>>>    <manifestclasspath jarfile="C:/Temp/e.jar"
>>>                       maxParentLevels="99" property="cp">
>>>      <classpath>
>>>        <pathelement location="D:/a/b/x.jar"/>
>>>      </classpath>
>>>    </manifestclasspath>
>>>  </target>
>>  </project>

> I don't get it Stefan. What is going to be in the manifest?

The task will fail because it cannot find a relative path (and the test
asserts the error).  FileUtils.getRelativePath returns the canonical
path of the target file.

> IMHO, a <manifest> classpath should only ever contain true relative paths,

It does.

> So I'm not sure the bug report is valid at all,

The report talked about problems when staying on the same drive, this
failed before I changed the code.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message