ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dominique Devienne <ddevie...@gmail.com>
Subject Re: svn commit: r812573 - in /ant/core/trunk/src: etc/testcases/taskdefs/manifestclasspath.xml main/org/apache/tools/ant/taskdefs/ManifestClassPath.java tests/junit/org/apache/tools/ant/taskdefs/ManifestClassPathTest.java
Date Tue, 08 Sep 2009 18:02:48 GMT
On Tue, Sep 8, 2009 at 11:16 AM, <bodewig@apache.org> wrote:
> Author: bodewig
> Date: Tue Sep  8 16:16:54 2009
> New Revision: 812573
>
> URL: http://svn.apache.org/viewvc?rev=812573&view=rev
> Log: Use FileUtils.getRelativePath which knows how to deal with drive letters.  PR 44499
> [...]
> +  <target name="testDifferentDrive">
> +    <manifestclasspath jarfile="C:/Temp/e.jar"
> +                       maxParentLevels="99" property="cp">
> +      <classpath>
> +        <pathelement location="D:/a/b/x.jar"/>
> +      </classpath>
> +    </manifestclasspath>
> +  </target>
>  </project>

I don't get it Stefan. What is going to be in the manifest?

AFAIK, there's no way to change drive (letter) with a relative path/filename.
You can't "cd .." when you're in D:\ or C:\ so how does one go from C: to D:
using a relative path??? cd /d allows changing drive letter, but takes an
absolute path, not a relative one.

IMHO, a <manifest> classpath should only ever contain true relative paths,
or absolute URLs (in which case one would need file:///D/a/b/x.jar and
D:/a/b/x.jar is not a valid entry for Class-Path: IMHO.)

So I'm not sure the bug report is valid at all, and why my original code didn't
allow changing drives, because AFAIK each drive is a "root" directory. --DD

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message