ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Reilly <peter.kitt.rei...@gmail.com>
Subject Re: Giving the improved bzip2 code a second chance?
Date Fri, 27 Mar 2009 09:42:31 GMT
On Fri, Mar 27, 2009 at 8:26 AM, Kevin Jackson <foamdino@gmail.com> wrote:
> Hi,
>
>> with Ant 1.7.0 we changed the bzip2 code to make it a lot faster and
>> reverted the change in 1.7.1 because it was creating corrupt archives.
>>
>> Meanwhile the Hadoop folks have been using the 1.7.0 code and claim
>> they have found and fixed the problem (a single + 1 missing somewhere
>> IIUC).
>>
>> I think we have a unit test that failed with the 1.7.0 code and passes
>> with 1.7.1 - should we give the Hadoop fixed code a second chance if
>> it passes all our tests?
>
> If it passes our tests (and Peter's extended test), why should we not
> use it?  +1 from me
>
+1 from me.

Peter

> Kev
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message