ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dominique Devienne <ddevie...@gmail.com>
Subject Re: encoding in ZIP package
Date Thu, 26 Feb 2009 17:48:55 GMT
On Thu, Feb 26, 2009 at 8:16 AM, Stefan Bodewig <bodewig@apache.org> wrote:
> over the past two weeks commons-compress has been adding stuff for
> more advanced ZIP features and I've merged the changes over to our zip
> package.  The changes bring two new options with them and I'd like to
> get some feedback as to which defaults our tasks should use wrt these
> options.
> [...]
> <zip>:
> * setLanguageEncodingFlag - doesn't do anything if the encoding is not
>  UTF-8.  Controls whether ZipOutputStream sets the flag.
>
>  I'd make that default to true.

Sounds reasonable.

> * createUnicodeExtraFields
>  Controls whether ZipOutputStream writes Unicode extra fields.
>
>  I'd make that default to false.
>
> <unzip>:

Same.

> * parseUnicodeExtraFields
>  Controls whether ZipFile searches for Unicode extra fields.
>
>  I'm uncertain as to what the default should be.

Don't know.

Not very helpful I'm afraid. I've read your message with interest, and
you obviously have thought thru a lot of the involved issues, and what
you write makes sense. Regarding parseUnicodeExtraFields, I'd keep the
existing behavior not now, the fact that the attribute exists to
resolve corner cases is enough in my mind.

There's only so much you can do when a loosely defined "format" like
zip, and IMHO you've done plenty already. --DD

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message