Return-Path: Delivered-To: apmail-ant-dev-archive@www.apache.org Received: (qmail 79995 invoked from network); 29 Jan 2009 16:59:53 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 29 Jan 2009 16:59:53 -0000 Received: (qmail 67692 invoked by uid 500); 29 Jan 2009 16:59:52 -0000 Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 67653 invoked by uid 500); 29 Jan 2009 16:59:52 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 67641 invoked by uid 99); 29 Jan 2009 16:59:52 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Jan 2009 08:59:52 -0800 X-ASF-Spam-Status: No, hits=-1.0 required=10.0 tests=RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of jak-ant-dev@m.gmane.org designates 80.91.229.2 as permitted sender) Received: from [80.91.229.2] (HELO ciao.gmane.org) (80.91.229.2) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Jan 2009 16:59:43 +0000 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1LSaEc-0007m8-L0 for dev@ant.apache.org; Thu, 29 Jan 2009 16:59:22 +0000 Received: from c-66-31-17-140.hsd1.ma.comcast.net ([66.31.17.140]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 29 Jan 2009 16:59:22 +0000 Received: from jesse.glick by c-66-31-17-140.hsd1.ma.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 29 Jan 2009 16:59:22 +0000 X-Injected-Via-Gmane: http://gmane.org/ To: dev@ant.apache.org From: Jesse Glick Subject: Re: Bugzilla Issue 45902 (Up-to-date checks for JARs broken due to comparison of dir timestamps) Date: Thu, 29 Jan 2009 11:59:13 -0500 Organization: Sun Microsystems / NetBeans Lines: 30 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: c-66-31-17-140.hsd1.ma.comcast.net User-Agent: Thunderbird 2.0.0.19 (X11/20090105) In-Reply-To: Sender: news X-Virus-Checked: Checked by ClamAV on apache.org Stefan Bodewig wrote: >>> * a single empty directory is added to the sources - I think Ant will >>> now no longer create a new archive > >> Is this really a bug? > > Some people say so > > https://issues.apache.org/bugzilla/show_bug.cgi?id=20366 True, although skipping dir timestamps just means that such a source change will not trigger a rebuild of the JAR during an incremental build. That can be expected to be a much rarer situation than doing a full build when the empty source dir already exists. > Did I sound like "if you think you understand Zip.java better than I > do"? If so, please forgive me, this was in no way intended. I just meant that you likely have a deeper understanding of Zip - and in particular the newer resource collection framework - than I do. My fix solved the case at hand, but there is likely a better fix somehow involving the dir entry creation code. > in many if not > most cases you don't really care for the timestamps of the directories > so even the second task shouldn't recreate the archive. Perhaps, although as far as I know it is relatively uncommon for a dir timestamp to change without the timestamp of any of the contained files to change, so if JARs are recreated in this situation it would not be a significant annoyance even if you care nothing for directory entry timestamps. > And if you > do, the third and fourth tasks shouldn't do anything. Right, that is the real bug in my mind. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org