Return-Path: Delivered-To: apmail-ant-dev-archive@www.apache.org Received: (qmail 28192 invoked from network); 28 Jan 2009 19:06:40 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 28 Jan 2009 19:06:40 -0000 Received: (qmail 60778 invoked by uid 500); 28 Jan 2009 19:06:38 -0000 Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 60733 invoked by uid 500); 28 Jan 2009 19:06:38 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 60722 invoked by uid 99); 28 Jan 2009 19:06:38 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Jan 2009 11:06:38 -0800 X-ASF-Spam-Status: No, hits=-1.0 required=10.0 tests=RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of jak-ant-dev@m.gmane.org designates 80.91.229.2 as permitted sender) Received: from [80.91.229.2] (HELO ciao.gmane.org) (80.91.229.2) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Jan 2009 19:06:29 +0000 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1LSFjh-0000la-JQ for dev@ant.apache.org; Wed, 28 Jan 2009 19:06:05 +0000 Received: from c-66-31-17-140.hsd1.ma.comcast.net ([66.31.17.140]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 28 Jan 2009 19:06:05 +0000 Received: from jesse.glick by c-66-31-17-140.hsd1.ma.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 28 Jan 2009 19:06:05 +0000 X-Injected-Via-Gmane: http://gmane.org/ To: dev@ant.apache.org From: Jesse Glick Subject: Re: Bugzilla Issue 45902 (Up-to-date checks for JARs broken due to comparison of dir timestamps) Date: Wed, 28 Jan 2009 14:05:52 -0500 Organization: Sun Microsystems / NetBeans Lines: 25 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: c-66-31-17-140.hsd1.ma.comcast.net User-Agent: Thunderbird 2.0.0.19 (X11/20090105) In-Reply-To: Sender: news X-Virus-Checked: Checked by ClamAV on apache.org Stefan Bodewig wrote: > has been changed to ignore directory resources The intent was to ignore timestamp changes in directory resources when determining whether or not to rebuild an existing JAR, not to ignore directories altogether. > * a single empty directory is added to the sources - I think Ant will > now no longer create a new archive Is this really a bug? I guess it depends on whether you consider directory entries in ZIP files valuable (other than the fact that it can cause problems for an entry to exist but its parent dir entry to not exist). > * we are updating a zip or reading from another ArchiveFileSet and the > directories have Unix permissions set that are different from the > tasks-level permissions - I'm afraid we are going to lose the > original permissions. Only during an incremental build after changing the source permissions, right? > there may be more problems with this approach. There may. Feel free to revert/fix if you think you understand Zip.java better than I do. Note that in my test case, creating and deleting y.properties changes the timestamp of the dir. It would be OK if Zip therefore recreated the archive _once_ (the "second" run). But it keeps on recreating it over and over, apparently because the timestamp of the dir entry does not get updated. If this problem can be fixed, then I guess we would have a more conservative fix for the bug. Probably in that case the first au:assertDestIsUptodate should be removed from the test case. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org