From dev-return-83927-apmail-ant-dev-archive=ant.apache.org@ant.apache.org Wed Jan 28 07:55:20 2009 Return-Path: Delivered-To: apmail-ant-dev-archive@www.apache.org Received: (qmail 40784 invoked from network); 28 Jan 2009 07:55:20 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 28 Jan 2009 07:55:20 -0000 Received: (qmail 77951 invoked by uid 500); 28 Jan 2009 07:55:19 -0000 Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 77891 invoked by uid 500); 28 Jan 2009 07:55:19 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 77880 invoked by uid 99); 28 Jan 2009 07:55:19 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Jan 2009 23:55:19 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of gscokart@gmail.com designates 72.14.220.152 as permitted sender) Received: from [72.14.220.152] (HELO fg-out-1718.google.com) (72.14.220.152) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Jan 2009 07:55:12 +0000 Received: by fg-out-1718.google.com with SMTP id 13so420511fge.22 for ; Tue, 27 Jan 2009 23:54:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=RswPxasJvVEePC5tpxdQou8bBIyBES86ry4W/vVr9+8=; b=UKyCL9+KY9JQcRzjeW8JkgWkq58zQ7hZHzPNVHv3YERCzGMvdPSigg0ODqV1VWnDxO APvYQV0BaZkCl00b6rlZHgPH9yG0kqAjRPzlvAmwNVEBjAIsGt3x1zIfVwyJd6vKOkjQ QMblBz1UTAjcUR0jZBg6RqUmGzTQmuIp8833E= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=HPump8SjsxoJ7jH2HJEG3UBOsBZ0RXXO01caC1N7/Iu4CdTvf7mcIOSx3+ffMsJcvp MHkYTIyd/lfUZiRGz8C/D2BXdbxAGkx8daa/FJLlwi976LLTZirbus9iLPOGugZF5Ak1 TeJFwd2B2eP7pPKbJRAsLvwJ4e4WtoM81zcz0= MIME-Version: 1.0 Received: by 10.223.112.132 with SMTP id w4mr1668986fap.67.1233129291308; Tue, 27 Jan 2009 23:54:51 -0800 (PST) In-Reply-To: References: Date: Wed, 28 Jan 2009 08:54:51 +0100 Message-ID: Subject: Re: Integration of antunit in junit From: Gilles Scokart To: Ant Developers List Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org OK, let's go for conditional compilation. I have dig deeper, and it might be possible to compile enterily the sources in a 1.4 format. You will just need to have a compiler able to read 1.5 classes (I guess junit 4 classes are in a 1.5 class format). But I think the antunit adapter might be plain old 1.4 classes. Also, probably one unit test will require 1.5 annotation. If that's the case, I will make it conditional also. Gilles Scokart 2009/1/28 Stefan Bodewig : > On 2009-01-27, Gilles Scokart wrote: > >> I finished a first step. I have refactored AntUnit task in order to >> extract the logic of running the antunit tests from the logic related >> to the interaction with the container project. Feedback are welcome. > > I like it. > >> I will now clean and check-in my junit runners. But this will have >> some impact. The first one is light. For a junit3 adapter, I will >> have to add Junit dependency. I plan to put it in a specific >> package, and use junit only from this package. I guess this one is >> OK. > > Yes, just make it compile conditionally. > > >> The second one is bigger. For junit4 adapter, I will have move to >> java 1.5. Is there an objection to move the entire antunit library to >> java 1.5? Or would you preffer to only compile a junit4 package with >> java 1.5 ? > > I'd prefer to keep AntUnit at the 1.4 level as long as the only reason > is to provide a JUnit4 adapter - there are several JDK 1.4 only cases > (like running inside Ant) that we should support. > > IMHO, put it into a separate package and make it compile > conditionally. > > Stefan > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org > For additional commands, e-mail: dev-help@ant.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org